Merge pull request #19390 from ramezgerges/textblock_wasm_inlines_crash

fix(TextBlock): clear old text when setting text through inlines

Author: ramezgerges

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs

@@ -19,6 +19,7 @@
 using static Private.Infrastructure.TestServices;
 using System.Collections.Generic;
 using System.Drawing;
+using SamplesApp.UITests;
 using Uno.Disposables;
 using Uno.Extensions;
 using Point = Windows.Foundation.Point;
@@ -610,6 +611,24 @@ public void When_Inlines_XamlRoot()
 			}
 		}
 
+#if __WASM__
+		[TestMethod]
+		[UnoWorkItem("https://github.com/unoplatform/uno/issues/19380")]
+		public async Task When_Changing_Text_Through_Inlines()
+		{
+			var SUT = new TextBlock { Text = "Initial Text" };
+			await Uno.UI.RuntimeTests.Helpers.UITestHelper.Load(SUT);
+			var width = Uno.UI.Xaml.WindowManagerInterop.GetClientViewSize(SUT.HtmlId).clientSize.Width;
+
+			SUT.Inlines.Clear();
+			SUT.Inlines.Add(new Run { Text = "Updated Text" });
+
+			await Uno.UI.RuntimeTests.Helpers.UITestHelper.WaitForIdle();
+
+			Uno.UI.Xaml.WindowManagerInterop.GetClientViewSize(SUT.HtmlId).clientSize.Width.Should().BeApproximately(width, precision: width * 0.4);
+		}
+#endif
+
 		[TestMethod]
 #if __MACOS__
 		[Ignore("Currently fails on macOS, part of #9282 epic")]

src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs

@@ -118,6 +118,9 @@ public InlineCollection Inlines
 				if (_inlines == null)
 				{
 					_inlines = new InlineCollection(this);
+#if __WASM__
+					SetText(string.Empty); // To clean up the text that is set directly on the TextBlock's <p>
+#endif
 					UpdateInlines(Text);
 
 					SetupInlines();

src/Uno.UI/UI/Xaml/UIElement.crossruntime.cs

@@ -102,11 +102,6 @@ private void OnChildRemoved(UIElement child)
 		{
 			child.Shutdown();
 
-			if (!child._isFrameworkElement)
-			{
-				return;
-			}
-
 #if UNO_HAS_ENHANCED_LIFECYCLE
 			var leaveParams = new LeaveParams(IsActiveInVisualTree);
 			child.Leave(leaveParams);