Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to provide 2 possible basepath #284

Open
baptisteArno opened this issue Jan 11, 2025 · 2 comments
Open

Be able to provide 2 possible basepath #284

baptisteArno opened this issue Jan 11, 2025 · 2 comments

Comments

@baptisteArno
Copy link
Contributor

Thanks for this useful CLI 🤘

I'm at a point where I'd need it to be able to check for 2 base path. One for assets (/public folder), the other for site pages (/app/routes folder)

Do you think we could also use micromatch for the basepath argument?

@karlhorky
Copy link
Member

karlhorky commented Jan 11, 2025

Sounds like a nice addition, would you be open to submitting this as a PR? Code should be fairly straightforward. One thing I would like to hear about before opening the PR: how does it work when you specify a micromatch pattern - does it check all possible paths? Maybe instead of a micromatch pattern, it should be a minimatch pattern, so that it can be used with Node.js glob support (fs/promises.glob docs)?

I probably won't have time until Q2 2025 at earliest to add features here, but I could probably review a PR.

@baptisteArno
Copy link
Contributor Author

Ok will work on that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants