Generate matrix env entries #13
Conversation
There was a problem hiding this comment.
I'm happy with this as is, but have a few comments you might like to address at this time.
Also what is urfave/gimme's policy for commits/messages? Personally, I would normally squash this if I was merging. Or I'd ask the author to squash it down to one commit per issue being addressed, but I don't think that's possible in this case as they are quite intertwined. CI changes are so hard to get right without multiple attempts. 😆
@brackendawson I think we're in the process of defining what the I personally try to keep the messy bits of the commit history as part of what's re-integrated into main as much as possible because:
All of that being said, and to your point about getting CI changes right, this is more messy than what I'd typically be comfortable merging 😂 What do you think about me pushing a selectively squashed rebase that trims down the CI change attempts? |
There was a problem hiding this comment.
I'd be happy with squashing the re-tries into the commits before them. Also giving my ✅ here anyway in case that turns out to be non-trivial. In lieu of a CONTRIBUTING.md to the contrary I don't think one can justify requesting changes to the number of commits.
plus other squashed CI fiddling: - Add a missing fromJson - Whoops actually run gimme - Filter gimme output to appease GITHUB_ENV - Use fromJson in the right place
including porting many Shell and Python things to Go
and trim down the list
and cut down on intermediate and platform-specific lists
so that it isn't re-generated at matrix time from a fresh known versions list
given feedback on #13
meatballhat
force-pushed
the
matrixize
branch
from
5f79962 to
13cdf4b
Compare
|
@brackendawson selective squashing done 👍🏼 |
(and arguably too many other cleanups along the way)
Closes #12
Closes #14
Closes #15