Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision 5 control si-3.9 doesn't have the non-zero padded label #280

Closed
KyungjinJPark opened this issue Oct 30, 2024 · 2 comments
Closed
Assignees
Labels
bug The issue is a bug report.

Comments

@KyungjinJPark
Copy link

Describe the bug

In the Revision 5 source XML, the si-3.9 control does not have the non-zero padded (classless) label. it also seems to be missing the class="zero-padded" one that the other controls seem to have, instead having two class="sp800-53a" labels.

src/nist.gov/SP800-53/rev5/xml/NIST_SP-800-53_rev5_catalog.xml lines 77352-77359:

      <control class="SP800-53-enhancement" id="si-3.9">
        <title>Authenticate Remote Commands</title>
+       <prop name="label" class="zero-padded" value="SI-03(09)"/>
+       <prop name="label" value="SI-3(9)"/>
-       <prop name="label" class="sp800-53a" value="SI-03(09)"/>
        <prop name="label" class="sp800-53a" value="SI-03(09)"/>
        <prop name="sort-id" value="si-03.09"/>
        <prop name="status" value="withdrawn"/>
        <link rel="moved-to" href="#ac-17.10"/>
      </control>

Who is the bug affecting?

Consumers reading from all formats (JSON, XML, and YAML) of the Revision 5 catalog at nist.gov/SP800-53/rev5 that use the non-padded control labels.

What is affected by this bug?

the si-3.9 control's labels

When does this occur?

always

How do we replicate the issue?

  1. inspect src/nist.gov/SP800-53/rev5/xml/NIST_SP-800-53_rev5_catalog.xml at lines 77352-77359
  2. inspect the resulting JSON, XML, and YAML catalogs

Expected behavior (i.e. solution)

class="zero-padded" and classless labels exist

Other Comments

Please let me know if this is a misunderstanding. I'm also willing to make the PR if we agree this is an issue.

@KyungjinJPark KyungjinJPark added the bug The issue is a bug report. label Oct 30, 2024
@KyungjinJPark KyungjinJPark changed the title The example files contain many typos Revision 5 control si-3.9 doesn't have the non-zero padded label Oct 30, 2024
@iMichaela
Copy link
Contributor

@KyungjinJPark - Thank you for identifying the bugs. We will address the typos and release the catalog and profiles with the fixes.

@iMichaela iMichaela self-assigned this Oct 30, 2024
iMichaela pushed a commit that referenced this issue Nov 1, 2024
@iMichaela
Copy link
Contributor

The bug was fixed and pushed to the develop branch, and it will be released with the next release.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in NIST OSCAL Work Board Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug report.
Projects
Status: Done
Development

No branches or pull requests

2 participants