Skip to content

Commit 1e7a760

Browse files
graycreateclaude
andcommitted
refactor: remove github build variant
- Remove github build variant from build.gradle - Keep only debug and release variants - Update CI/CD workflows to remove github variant references - Update documentation in CLAUDE.md - Debug variant uses default Android debug signing - Release variant uses keystore from KEYSTORE_BASE64 secret Simplifies the build configuration by removing unnecessary variant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 8b6cb35 commit 1e7a760

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
echo "## APK Build Results :package:" >> $GITHUB_STEP_SUMMARY
9292
echo "" >> $GITHUB_STEP_SUMMARY
9393
94-
APK_PATH=$(find app/build/outputs/apk -name "*.apk" | grep -E "(release|github)" | head -1)
94+
APK_PATH=$(find app/build/outputs/apk -name "*.apk" | grep -E "release" | head -1)
9595
if [ -f "$APK_PATH" ]; then
9696
APK_SIZE=$(du -h "$APK_PATH" | cut -f1)
9797
echo "- APK Size: $APK_SIZE" >> $GITHUB_STEP_SUMMARY
@@ -181,7 +181,7 @@ jobs:
181181
id: assets
182182
run: |
183183
# Find APK
184-
APK_PATH=$(find release-artifacts -name "*.apk" | grep -E "(release|github)" | head -1)
184+
APK_PATH=$(find release-artifacts -name "*.apk" | grep -E "release" | head -1)
185185
if [ -f "$APK_PATH" ]; then
186186
APK_NAME="v2er-${{ needs.prepare.outputs.version }}.apk"
187187
mv "$APK_PATH" "$APK_NAME"

CLAUDE.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
1212
# Build release APK (requires GHUI_KEYSTORE_PASSWORD and GHUI_KEY_PASSWORD env vars)
1313
./gradlew assembleRelease
1414

15-
# Build GitHub variant (for CI/CD)
16-
./gradlew assembleGithub
17-
1815
# Clean and rebuild
1916
./gradlew clean assembleDebug
2017
```
@@ -112,7 +109,6 @@ The app follows MVP (Model-View-Presenter) architecture with dependency injectio
112109
3. **Build Variants**:
113110
- `debug`: Standard development build
114111
- `release`: Production build (requires keystore passwords)
115-
- `github`: CI/CD variant with embedded signing config
116112

117113
4. **Permissions**:
118114
- Internet access
@@ -128,10 +124,12 @@ The app follows MVP (Model-View-Presenter) architecture with dependency injectio
128124

129125
### GitHub Actions
130126
The project uses GitHub Actions for continuous integration:
131-
- **Workflow**: `.github/workflows/android.yml`
127+
- **CI Workflow**: `.github/workflows/ci.yml` - Runs tests, lint, and builds
128+
- **Release Workflow**: `.github/workflows/release.yml` - Creates signed releases
129+
- **Dependency Updates**: `.github/workflows/dependency-update.yml` - Weekly checks
132130
- **Trigger**: Push and pull requests to main branch
133-
- **JDK Version**: 11
134-
- **Build Command**: `./gradlew build`
131+
- **JDK Version**: 17
132+
- **Build Commands**: Various gradle tasks for test, lint, and build
135133

136134
### Release Signing
137135
Release builds require environment variables:
@@ -140,7 +138,6 @@ Release builds require environment variables:
140138
- GitHub secrets also include:
141139
- `KEYSTORE_BASE64`: Base64-encoded keystore file
142140
- `KEY_ALIAS`: Key alias for signing
143-
- GitHub variant has embedded signing config for CI/CD
144141

145142
## Project Configuration
146143

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ android {
3737
}
3838

3939
buildTypes {
40-
github {
41-
signingConfig signingConfigs.debug
40+
debug {
41+
// Debug build type uses default debug signing
4242
}
4343

4444
release {

0 commit comments

Comments
 (0)