fix: fix YAML syntax in release workflow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: vakovalskii

.github/workflows/release.yml

@@ -3,30 +3,25 @@ name: Release
 on:
   push:
     tags:
-      - 'v*'
+      - "v*"
   workflow_dispatch:
-    inputs:
-      tag:
-        description: 'Release tag (e.g. v0.0.9)'
-        required: false
 
 permissions:
   contents: write
 
 env:
-  NODE_VERSION: '20'
-  RUST_VERSION: 'stable'
+  NODE_VERSION: "20"
 
 jobs:
   build:
     strategy:
       fail-fast: false
       matrix:
         include:
-          - platform: macos-latest    # ARM64 (Apple Silicon)
+          - platform: macos-latest
             target: aarch64-apple-darwin
             os_name: macos-arm64
-          - platform: macos-13        # Intel
+          - platform: macos-13
             target: x86_64-apple-darwin
             os_name: macos-x64
           - platform: ubuntu-22.04
@@ -38,162 +33,120 @@ jobs:
 
     runs-on: ${{ matrix.platform }}
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: npm
 
-      - name: Setup Rust
-        uses: dtolnay/rust-toolchain@stable
+      - uses: dtolnay/rust-toolchain@stable
         with:
           targets: ${{ matrix.target }}
 
-      - name: Rust cache
-        uses: swatinem/rust-cache@v2
+      - uses: swatinem/rust-cache@v2
         with:
           workspaces: src-tauri -> target
           key: ${{ matrix.target }}
 
       - name: Install Tauri CLI
         run: cargo install tauri-cli --locked
 
-      # Linux dependencies
-      - name: Install Linux dependencies
-        if: contains(matrix.platform, 'ubuntu')
+      - name: Install Linux deps
+        if: runner.os == 'Linux'
         run: |
           sudo apt-get update
           sudo apt-get install -y \
-            libwebkit2gtk-4.1-dev \
-            libappindicator3-dev \
-            librsvg2-dev \
-            patchelf \
-            libgtk-3-dev \
-            libsoup-3.0-dev \
-            libjavascriptcoregtk-4.1-dev
-
-      # macOS: Import signing certificate (skip if secrets not configured)
+            libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev \
+            patchelf libgtk-3-dev libsoup-3.0-dev libjavascriptcoregtk-4.1-dev
+
       - name: Import Apple certificate
-        if: contains(matrix.platform, 'macos') && env.APPLE_CERTIFICATE != ''
+        if: runner.os == 'macOS' && secrets.APPLE_CERTIFICATE != ''
         env:
           APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
           APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
           KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }}
         run: |
-          CERTIFICATE_PATH=$RUNNER_TEMP/certificate.p12
-          KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db
-
-          echo -n "$APPLE_CERTIFICATE" | base64 --decode -o $CERTIFICATE_PATH
-
-          security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
-          security set-keychain-settings -lut 21600 $KEYCHAIN_PATH
-          security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
+          CERT=$RUNNER_TEMP/cert.p12
+          KC=$RUNNER_TEMP/signing.keychain-db
+          echo -n "$APPLE_CERTIFICATE" | base64 --decode -o $CERT
+          security create-keychain -p "$KEYCHAIN_PASSWORD" $KC
+          security set-keychain-settings -lut 21600 $KC
+          security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KC
+          security import $CERT -P "$APPLE_CERTIFICATE_PASSWORD" -A -t cert -f pkcs12 -k $KC
+          security set-key-partition-list -S apple-tool:,apple: -k "$KEYCHAIN_PASSWORD" $KC
+          security list-keychain -d user -s $KC
+
+      - run: npm ci
 
-          security import $CERTIFICATE_PATH -P "$APPLE_CERTIFICATE_PASSWORD" \
-            -A -t cert -f pkcs12 -k $KEYCHAIN_PATH
-          security set-key-partition-list -S apple-tool:,apple: \
-            -k "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
-          security list-keychain -d user -s $KEYCHAIN_PATH
-
-      - name: Install npm dependencies
-        run: npm ci
-
-      # Build frontend
       - name: Build frontend
         run: npm run build
 
-      # Build sidecar
       - name: Build sidecar
         run: npm run build:sidecar
 
-      # Build Tauri app
-      - name: Build Tauri (macOS)
-        if: contains(matrix.platform, 'macos')
+      - name: Build Tauri
         env:
-          TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
-          TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
-          APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_CERTIFICATE != '' && 'Developer ID Application: Valeriy Kovalsky (A933C2TJXU)' || '-' }}
+          APPLE_SIGNING_IDENTITY: "Developer ID Application: Valeriy Kovalsky (A933C2TJXU)"
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
           APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
-        run: |
-          cd src-tauri && cargo tauri build --target ${{ matrix.target }}
+        run: cd src-tauri && cargo tauri build --target ${{ matrix.target }}
 
-      - name: Build Tauri (Linux)
-        if: contains(matrix.platform, 'ubuntu')
-        run: |
-          cd src-tauri && cargo tauri build --target ${{ matrix.target }}
-
-      - name: Build Tauri (Windows)
-        if: contains(matrix.platform, 'windows')
-        run: |
-          cd src-tauri && cargo tauri build --target ${{ matrix.target }}
-
-      # macOS: Notarize (only if certificate is configured)
       - name: Notarize macOS DMG
-        if: contains(matrix.platform, 'macos') && secrets.APPLE_CERTIFICATE != ''
+        if: runner.os == 'macOS' && secrets.APPLE_ID != ''
         env:
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
           APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
         run: |
-          DMG=$(find src-tauri/target/${{ matrix.target }}/release/bundle/dmg -name "*.dmg" | head -1)
+          DMG=$(find src-tauri/target/${{ matrix.target }}/release/bundle/dmg -name "*.dmg" 2>/dev/null | head -1)
           if [ -n "$DMG" ]; then
-            echo "Notarizing: $DMG"
             xcrun notarytool submit "$DMG" \
-              --apple-id "$APPLE_ID" \
-              --password "$APPLE_PASSWORD" \
-              --team-id "$APPLE_TEAM_ID" \
-              --wait
-            xcrun stapler staple "$DMG"
+              --apple-id "$APPLE_ID" --password "$APPLE_PASSWORD" --team-id "$APPLE_TEAM_ID" --wait || true
+            xcrun stapler staple "$DMG" || true
           fi
 
-      # Upload artifacts
       - name: Upload macOS artifacts
-        if: contains(matrix.platform, 'macos')
+        if: runner.os == 'macOS'
         uses: actions/upload-artifact@v4
         with:
           name: ValeDesk-${{ matrix.os_name }}
-          path: |
-            src-tauri/target/${{ matrix.target }}/release/bundle/dmg/*.dmg
+          path: src-tauri/target/${{ matrix.target }}/release/bundle/dmg/*.dmg
+          if-no-files-found: ignore
 
       - name: Upload Linux artifacts
-        if: contains(matrix.platform, 'ubuntu')
+        if: runner.os == 'Linux'
         uses: actions/upload-artifact@v4
         with:
           name: ValeDesk-${{ matrix.os_name }}
           path: |
             src-tauri/target/${{ matrix.target }}/release/bundle/appimage/*.AppImage
             src-tauri/target/${{ matrix.target }}/release/bundle/deb/*.deb
+          if-no-files-found: ignore
 
       - name: Upload Windows artifacts
-        if: contains(matrix.platform, 'windows')
+        if: runner.os == 'Windows'
         uses: actions/upload-artifact@v4
         with:
           name: ValeDesk-${{ matrix.os_name }}
           path: |
             src-tauri/target/${{ matrix.target }}/release/bundle/msi/*.msi
             src-tauri/target/${{ matrix.target }}/release/bundle/nsis/*.exe
+          if-no-files-found: ignore
 
-  # Create GitHub Release
   release:
     needs: build
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/tags/v')
     steps:
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v4
         with:
           path: artifacts
 
-      - name: List artifacts
-        run: find artifacts -type f | sort
+      - run: find artifacts -type f | sort
 
-      - name: Create Release
-        uses: softprops/action-gh-release@v2
+      - uses: softprops/action-gh-release@v2
         with:
           draft: true
           generate_release_notes: true