Skip to content

Conversation

@travisbartholome
Copy link

Changes

XLCore updated the wine binary path recently in this commit: goatcorp/XIVLauncher.Core@877cfd1

Updating the setup script to check for the new path. If new path exists, will use it, otherwise will fall back to old path for backwards compatibility.

Testing

Confirmed running ./setup.sh finds the correct wine paths with new XLCore version:

Detected the following information about your setup. If any of this looks incorrect, please abort and report a bug to the Github repo...
Runtime Environment: AUR XIVLauncher.Core
FFXIV Game Location: /home/travis/.xlcore/ffxiv
wine Executable Location: /home/travis/.xlcore/compatibilitytool/wine/wine-xiv-staging-fsync-git-10.8.r0.g47f77594-nolsc/bin/wine
wine Distribution Path: /home/travis/.xlcore/compatibilitytool/wine/wine-xiv-staging-fsync-git-10.8.r0.g47f77594-nolsc
Wine Prefix: /home/travis/.xlcore/wineprefix
XIVLauncher Windows Path: /opt/XIVLauncher/XIVLauncher.Core

Comment on lines +140 to +146
if [[ -d "$HOME/.xlcore/compatibilitytool/wine" ]]; then
# For versions of XLCore since https://github.com/goatcorp/XIVLauncher.Core/commit/877cfd14dd686dacc65aafd01ad38c5de4337ab6
XLCORE_WINE_BASE_DIR="$HOME/.xlcore/compatibilitytool/wine"
else
# For older XLCore versions
XLCORE_WINE_BASE_DIR="$HOME/.xlcore/compatibilitytool/beta"
fi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this logic cause issues with installations that were upgraded from an older version? e.g. does XLCore properly remove the old beta folder?

Alternatively, is there a reasonable way to just read the current path from XLCore's config somehow?

Copy link
Author

@travisbartholome travisbartholome Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wiped my old wine prefix at some point while trying to upgrade so I can't fully confirm, but I think it doesn't remove the old wine in beta folder. Reasoning: my original problem was that I updated XIVLauncher AUR package but not ffxiv-tools generated scripts, and then FFXIV was running on a much newer wine version than ACT, so I think the old path was still valid and ACT was trying to run on it.

This is why the logic is looking for the new path first and falling back to the old one, rather than the other way around - so even if the old one is still there, we'll choose the new one. I think it should be safe but lmk if I'm missing a detail there.

Not sure if the path is stored directly in config but I think it's not if you use the default wine managed by xlcore (just says "Managed" in the config file iirc). I can confirm once back home in a couple days.

Copy link
Author

@travisbartholome travisbartholome Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah, confirmed that XLCore's launcher.ini just contains WineStartupType=Managed for this case, and no path info. Also looked around elsewhere and didn't see anything else.

Seems hardcoding the path may still be the only option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants