Skip to content

Check for duplicate nodeids when loading nodes.conf #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjoy-binbin wants to merge 4 commits into
base: unstable
Choose a base branch
from
+15 −0
Open

Check for duplicate nodeids when loading nodes.conf #2852

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfa8d6b
Check for duplicate nodeids when loading nodes.conf
enjoy-binbin Nov 17, 2025
96159e0
more code
enjoy-binbin Nov 17, 2025
53f36ae
Merge remote-tracking branch 'upstream/unstable' into dup_nodeid
enjoy-binbin Dec 2, 2025
d2db058
code review
enjoy-binbin Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/cluster_legacy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,10 @@ int clusterLoadConfig(char *filename) {
if (!n) {
n = createClusterNode(argv[0], 0);
clusterAddNode(n);
} else {
serverLog(LL_WARNING, "Duplicate nodeid detected: %s", argv[0]);
sdsfreesplitres(argv, argc);
goto fmterr;
}
/* Format for the node address and auxiliary argument information:
* ip:port[@cport][,hostname][,aux=val]*] */
Expand Down
Loading