Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support re-queueing stuck jobs #17

Open
jdmcd opened this issue Jun 13, 2019 · 6 comments · Fixed by #18
Open

Support re-queueing stuck jobs #17

jdmcd opened this issue Jun 13, 2019 · 6 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@jdmcd
Copy link
Member

jdmcd commented Jun 13, 2019

In order to fully complete conformance with the reliable queue pattern, the library should expose a hook that allows drivers to move idle jobs in processing back to the upcoming queue stack. This would be useful for jobs that get stuck if the process crashes.
@jdmcd jdmcd mentioned this issue Jun 13, 2019
Merged
@jdmcd jdmcd closed this as completed in #18 Jun 13, 2019
@jdmcd jdmcd reopened this Jun 13, 2019
@tanner0101 tanner0101 added the enhancement New feature or request label Jun 13, 2019
@Andrewangeta
Copy link
Member

@tanner0101 is this something that might make it into RC tags? Or a future RC?

@jdmcd
Copy link
Member Author

jdmcd commented Feb 28, 2020

I'd love to get it into the first RC but to be honest I haven't even scoped out what this feature looks like yet. I might have some time this weekend to take a look

@Andrewangeta
Copy link
Member

Sounds good. Ping me if you want some assistance in researching what this could look like.

@jdmcd
Copy link
Member Author

jdmcd commented Feb 28, 2020

Will do, thank you!

@jjabo
Copy link

jjabo commented Aug 18, 2021

Is this still being researched? The current queue is not 'reliable', rather jobs that are dequeued by a worker are lost if the e.g. the worker crashes.

@jdmcd
Copy link
Member Author

jdmcd commented Aug 21, 2021

@jjabo I have not looked at this in a while but would definitely want to add it if I ever had the time. But would be happy to review a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add delay property vapor/queues
4 participants
@tanner0101 @jjabo @jdmcd @Andrewangeta