varlink/scanner.py: early exit in case of invalid dict.

No behaviour change since the scanner would end up returning InvalidParam
anyway after exhausting all other possible types.

Author: Rémy Noel

varlink/scanner.py

@@ -291,7 +291,7 @@ def filter_params(self, parent_name, varlink_type, _namespaced, args, kwargs):
                     )
                 return args
             else:
-                InvalidParameter(parent_name)
+                raise InvalidParameter(parent_name)
 
         if isinstance(varlink_type, _CustomType):
             # print("CustomType", varlink_type.name)

varlink/tests/test_scanner.py

@@ -126,9 +126,14 @@ def test_bad_types(self):
         interface = varlink.Interface("""
         interface org.example.testerrors
         type TypeEnum ( a, b, c )
+        type TypeDict (dict: [string]string)
 
         method Foo(param: TypeEnum) -> ()
+        method Bar(param: TypeDict) -> ()
         """)
         foo = interface.get_method("Foo")
         with self.assertRaises(varlink.InvalidParameter):
             interface.filter_params("test.call", foo.in_type, False, (), {"param": "d"})
+        bar = interface.get_method("Bar")
+        with self.assertRaises(varlink.InvalidParameter):
+            interface.filter_params("test.call", bar.in_type, False, (), {"param": {"dict": [1, 2, 3]}})