Skip to content

Commit 85858ee

Browse files
committed
treewide: drop Python2 imports and version checks
1 parent e03a871 commit 85858ee

12 files changed

Lines changed: 18 additions & 141 deletions

varlink/__init__.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,19 @@
1919
__all__ = ['Client', 'ClientInterfaceHandler', 'SimpleClientInterfaceHandler',
2020
'Service', 'RequestHandler', 'Server', 'ThreadingServer', 'ForkingServer',
2121
'InterfaceNotFound', 'MethodNotFound', 'MethodNotImplemented', 'InvalidParameter',
22-
'ConnectionError', 'VarlinkEncoder', 'VarlinkError',
22+
'VarlinkEncoder', 'VarlinkError',
2323
'Interface', 'Scanner', 'get_listen_fd']
2424
from .server import ForkingServer
2525
else:
2626
__all__ = ['Client', 'ClientInterfaceHandler', 'SimpleClientInterfaceHandler',
2727
'Service', 'RequestHandler', 'Server', 'ThreadingServer',
2828
'InterfaceNotFound', 'MethodNotFound', 'MethodNotImplemented', 'InvalidParameter',
29-
'ConnectionError', 'VarlinkEncoder', 'VarlinkError',
29+
'VarlinkEncoder', 'VarlinkError',
3030
'Interface', 'Scanner', 'get_listen_fd']
3131

3232
from .client import (Client, ClientInterfaceHandler, SimpleClientInterfaceHandler)
3333
from .error import (VarlinkEncoder, VarlinkError, InvalidParameter, InterfaceNotFound, MethodNotImplemented,
34-
MethodNotFound, ConnectionError, BrokenPipeError)
34+
MethodNotFound)
3535
from .scanner import (Scanner, Interface)
3636
from .server import (Service, get_listen_fd, Server, ThreadingServer, RequestHandler)
3737

@@ -51,8 +51,6 @@ def load_tests(loader, tests, pattern):
5151
test_dir = os.path.dirname(__file__) + "/tests"
5252
for fn in os.listdir(test_dir):
5353
if fnmatch(fn, pattern):
54-
if sys.version_info[0] == 2 and fn == "test_mocks.py":
55-
continue
5654
modname = "varlink.tests." + fn[:-3]
5755
__import__(modname)
5856
module = sys.modules[modname]

varlink/cli.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
77
"""
88

9-
from __future__ import print_function
10-
from __future__ import unicode_literals
11-
129
import argparse
1310
import json
1411
import shlex
@@ -60,7 +57,7 @@ def new_client(address):
6057
got = True
6158
except varlink.VarlinkError as e:
6259
print(e, file=sys.stderr)
63-
except varlink.BrokenPipeError:
60+
except BrokenPipeError:
6461
if not got or args.more:
6562
print("Connection closed")
6663
sys.exit(1)

varlink/client.py

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# coding=utf-8
22

3-
from __future__ import print_function
4-
from __future__ import unicode_literals
5-
63
import json
74
import os
85
import shutil
@@ -13,28 +10,9 @@
1310
import subprocess
1411
import threading
1512

16-
try:
17-
from builtins import next
18-
from builtins import object
19-
from builtins import open
20-
from builtins import str
21-
except ImportError:
22-
pass
23-
24-
from .error import (VarlinkError, InterfaceNotFound, VarlinkEncoder, BrokenPipeError)
13+
from .error import (VarlinkError, InterfaceNotFound, VarlinkEncoder)
2514
from .scanner import (Interface, _Method)
2615

27-
PY2 = sys.version_info[0] == 2
28-
PY3 = (sys.version_info[0] >= 3)
29-
30-
if PY2:
31-
FileNotFoundError = IOError
32-
ChildProcessError = OSError
33-
34-
35-
class ConnectionError(OSError):
36-
pass
37-
3816

3917
class ClientInterfaceHandler(object):
4018
"""Base class for varlink client, which wraps varlink methods of an interface to the class"""
@@ -88,10 +66,7 @@ def _wrapped(*args, **kwargs):
8866
else:
8967
return self._call(method.name, *args, **kwargs)
9068

91-
if sys.version_info.major >= 3:
92-
_wrapped.__name__ = method.name
93-
else:
94-
_wrapped.__name__ = method.name.encode("latin-1")
69+
_wrapped.__name__ = method.name
9570

9671
# FIXME: add comments
9772
if method.signature:

varlink/error.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,7 @@
1-
from __future__ import print_function
2-
from __future__ import unicode_literals
3-
41
import json
52

6-
try:
7-
from types import SimpleNamespace
8-
9-
ConnectionError = ConnectionError
10-
BrokenPipeError = BrokenPipeError
11-
except: # Python 2
12-
from argparse import Namespace as SimpleNamespace
13-
14-
15-
class ConnectionError(OSError):
16-
pass
17-
183

19-
class BrokenPipeError(ConnectionError):
20-
pass
4+
from types import SimpleNamespace
215

226

237
class VarlinkEncoder(json.JSONEncoder):

varlink/mock.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
import varlink
1111

1212

13-
if sys.version_info[0] == 2:
14-
raise ImportError("The mock module isn't compatible with python 2")
15-
16-
1713
def cast_type(typeof):
1814
cast = {'str': 'string'}
1915
typeof = str(typeof).replace("<class '", "").replace("'>", "")

varlink/scanner.py

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,9 @@
11
#!-*-coding:utf8-*-
2-
from __future__ import print_function
3-
from __future__ import unicode_literals
4-
5-
try:
6-
from builtins import str
7-
from builtins import int
8-
from builtins import object
9-
from builtins import unicode
10-
except ImportError:
11-
pass
122

133
import re
144

15-
try:
16-
basestring
17-
except NameError:
18-
basestring = str
19-
20-
try:
21-
from types import SimpleNamespace
22-
except: # Python 2
23-
from argparse import Namespace as SimpleNamespace
24-
25-
try:
26-
from collections.abc import (Set, Mapping)
27-
except: # Python 2
28-
from collections import (Set, Mapping)
5+
from types import SimpleNamespace
6+
from collections.abc import (Set, Mapping)
297

308
from collections import OrderedDict
319

@@ -341,7 +319,7 @@ def filter_params(self, parent_name, varlink_type, _namespaced, args, kwargs):
341319
if isinstance(varlink_type, _Object):
342320
return args
343321

344-
if isinstance(varlink_type, _Enum) and ( isinstance(args, str) or isinstance(args, unicode) ):
322+
if isinstance(varlink_type, _Enum) and isinstance(args, str):
345323
# print("Returned str:", args)
346324
return args
347325

@@ -356,7 +334,7 @@ def filter_params(self, parent_name, varlink_type, _namespaced, args, kwargs):
356334
# print("Returned set:", set(args))
357335
return set(args)
358336

359-
if isinstance(varlink_type, basestring) and isinstance(args, basestring):
337+
if isinstance(varlink_type, str) and isinstance(args, str):
360338
return args
361339

362340
if isinstance(varlink_type, float) and (isinstance(args, float) or isinstance(args, int)):

varlink/server.py

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,20 @@
11
# coding=utf-8
22

3-
from __future__ import print_function
4-
from __future__ import unicode_literals
5-
63
import inspect
74
import json
85
import os
96
import socket
107
import stat
118
import string
129

13-
try:
14-
from builtins import int
15-
from builtins import object
16-
from builtins import open
17-
from builtins import range
18-
except ImportError:
19-
pass
20-
21-
from .error import (InterfaceNotFound, InvalidParameter, MethodNotImplemented, VarlinkEncoder, VarlinkError,
22-
ConnectionError)
10+
from .error import (InterfaceNotFound, InvalidParameter, MethodNotImplemented, VarlinkEncoder, VarlinkError)
2311
from .scanner import Interface
2412

25-
try:
26-
from socketserver import (StreamRequestHandler, BaseServer, ThreadingMixIn)
27-
except ImportError: # Python2
28-
from SocketServer import (StreamRequestHandler, BaseServer, ThreadingMixIn)
13+
14+
from socketserver import (StreamRequestHandler, BaseServer, ThreadingMixIn)
2915

3016
if hasattr(os, "fork"):
31-
try:
32-
from socketserver import ForkingMixIn
33-
except ImportError: # Python2
34-
from SocketServer import ForkingMixIn
17+
from socketserver import ForkingMixIn
3518

3619
from types import GeneratorType
3720

varlink/tests/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
def suite():
99
suite = unittest.TestSuite()
1010
for fn in os.listdir(here):
11-
if fn.startswith("test_mocks") and sys.version_info.major < 3:
12-
continue
13-
1411
if fn.startswith("test") and fn.endswith(".py"):
1512
modname = "varlink.tests." + fn[:-3]
1613
__import__(modname)

varlink/tests/test_basic_network.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
1-
from __future__ import print_function
2-
from __future__ import unicode_literals
3-
41
import os
52
import socket
63
import threading
74
import unittest
85
from sys import platform
96

10-
try:
11-
from builting import str
12-
except ImportError:
13-
pass
147

158
import varlink
169

@@ -70,5 +63,5 @@ def test_unix(self):
7063
)
7164

7265
def test_wrong_url(self):
73-
self.assertRaises(varlink.ConnectionError, self.do_run,
66+
self.assertRaises(ConnectionError, self.do_run,
7467
"uenix:org.varlink.service_wrong_url_test_%d" % os.getpid())

varlink/tests/test_certification.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#!/usr/bin/env python
22

3-
from __future__ import print_function
4-
from __future__ import unicode_literals
5-
63
import codecs
74
import getopt
85
import json
@@ -16,13 +13,6 @@
1613
import unittest
1714
from sys import platform
1815

19-
try:
20-
from builtins import object
21-
from builtins import range
22-
from builtins import str
23-
except ImportError:
24-
pass
25-
2616
import varlink
2717

2818

0 commit comments

Comments
 (0)