Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Normalize config materialization #259

Open
binarylogic opened this issue Mar 15, 2018 · 1 comment
Open

Normalize config materialization #259

binarylogic opened this issue Mar 15, 2018 · 1 comment
Assignees
Milestone

Comments

@binarylogic
Copy link
Contributor

Timber's various configuration parameters do not consistently support pulling values via a {:system, "VAR_NAME"} tuple. For example, Timber.Config.api_key/0 does, yet Timber.Config.http_url/0 does not. This makes it challenging to change all configuration URLs via environment variables.

@DavidAntaramian
Copy link
Contributor

We should follow common guidance on library configuration as given in http://michal.muskala.eu/2017/07/30/configuring-elixir-libraries.html#recommendations-for-library-authors

More generically, the configuration should be modifiable at runtime. This allows for users to choose their configuration methodology rather than binding it to a specific type of mechanism. In that regard, it allows users to pull in configuration by their own method (whether that be System.get_env/1 or some other mechanism like etcd or consul).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants