fix metadata insert/delete (#13196)

Author: fuchsnj

lib/vector-core/src/event/vrl_target.rs

@@ -310,7 +310,7 @@ impl MetadataTarget for VrlTarget {
     }
 
     fn remove_metadata(&mut self, path: &LookupBuf) -> Result<(), String> {
-        self.metadata_mut().value_mut().remove_by_path(path, true);
+        self.metadata_mut().value_mut().remove_by_path(path, false);
         Ok(())
     }
 }

lib/vector-vrl-functions/src/set_metadata_field.rs

@@ -14,7 +14,7 @@ fn set_metadata_field(
             Value::Null
         }
         MetadataKey::Query(query) => {
-            ctx.target_mut().remove_metadata(query.path())?;
+            ctx.target_mut().set_metadata(query.path(), value)?;
             Value::Null
         }
     })

lib/vrl/core/src/target.rs

@@ -112,7 +112,7 @@ impl MetadataTarget for TargetValueRef<'_> {
     }
 
     fn remove_metadata(&mut self, path: &LookupBuf) -> Result<(), String> {
-        self.metadata.remove_by_path(path, true);
+        self.metadata.remove_by_path(path, false);
         Ok(())
     }
 }
@@ -168,7 +168,7 @@ impl MetadataTarget for TargetValue {
     }
 
     fn remove_metadata(&mut self, path: &LookupBuf) -> Result<(), String> {
-        self.metadata.remove_by_path(path, true);
+        self.metadata.remove_by_path(path, false);
         Ok(())
     }
 }

lib/vrl/tests/tests/functions/metadata_read_write_delete.vrl

@@ -0,0 +1,14 @@
+# result:
+# {
+#    "a": {"foo": {"a": 1, "b": 2}},
+#    "b": {"foo": {"b": 2}},
+#    "c": {"foo": {}}
+# }
+
+set_metadata_field(.foo, {"a": 1, "b": 2})
+.a = get_metadata_field(.)
+remove_metadata_field(.foo.a)
+.b = get_metadata_field(.)
+remove_metadata_field(.foo.b)
+.c = get_metadata_field(.)
+.