Skip to content

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Nov 6, 2025

Summary

Sets the homebrew token to prevent push from failing

Vector configuration

NA

How did you test this PR?

No way to test without releasing

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@thomasqueirozb thomasqueirozb requested a review from a team as a code owner November 6, 2025 19:07
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Nov 6, 2025
@thomasqueirozb thomasqueirozb added domain: releasing Anything related to releasing Vector no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Nov 6, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is quite hard to test this. I still think we should follow this plan instead: #24139 (comment)

@github-actions github-actions bot removed the domain: releasing Anything related to releasing Vector label Nov 6, 2025
- `git switch "${RELEASE_BRANCH}" && git merge --ff-only "${PREP_BRANCH}"`

- [ ] Tag new release
- [ ] Create new ephemeral GitHub PAT and update the `HOMEBREW_PAT` [secret](https://github.com/vectordotdev/vector/settings/secrets/actions/HOMEBREW_PAT).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 This step introduces an extra manual step. Obviously it would be best if fully automated but it seems challenging because it involves pushing to another repo. At this point, would it be better if we just removed this from publish.yml and added a note for the maintainer to run it manually? The homebrew.rs works as is when ran locally outside the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish homebrew fails during release

3 participants