-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(releasing): homebrew set remote url with creds #24180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is quite hard to test this. I still think we should follow this plan instead: #24139 (comment)
| - `git switch "${RELEASE_BRANCH}" && git merge --ff-only "${PREP_BRANCH}"` | ||
|
|
||
| - [ ] Tag new release | ||
| - [ ] Create new ephemeral GitHub PAT and update the `HOMEBREW_PAT` [secret](https://github.com/vectordotdev/vector/settings/secrets/actions/HOMEBREW_PAT). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 This step introduces an extra manual step. Obviously it would be best if fully automated but it seems challenging because it involves pushing to another repo. At this point, would it be better if we just removed this from publish.yml and added a note for the maintainer to run it manually? The homebrew.rs works as is when ran locally outside the CI.
Summary
Sets the homebrew token to prevent push from failing
Vector configuration
NA
How did you test this PR?
No way to test without releasing
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.