Allow RSA key imports! (#96)

* Sort tests where lowercase comes first

* move jacobi symbol to cryptomathmodule from numpopsutils and remove unused class in number.star

* Add unittest runner for test_import_RSA.star. Now they run, and obviously fail.

* Surefire v3 test for larky

* second test working..

* Export private key

* commit failing tests

* Working test for pem decoding encoded with PKCS#1

* checkpoint, drew you now take over

* working test_export_public key!

* going for it

* importing it

* tests work!

* tests are passing, 1 by 1

* more passing tests

* more tests passing

* end of all working tests, we are 22 away from full test suite coverage

* Make it a test

* Update tests suite run breakdown

* fix codecs

Co-authored-by: aslepakurov <a.slepakurov@gmail.com>

Author: mahmoudimus

larky/pom.xml

@@ -34,6 +34,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <maven.source.plugin.version>3.2.1</maven.source.plugin.version>
         <maven.compiler.plugin.version>3.6.2</maven.compiler.plugin.version>
+        <surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
         <libstarlark.version>1.0-SNAPSHOT</libstarlark.version>
         <org.projectlombok.version>1.18.12</org.projectlombok.version>
         <common.io.version>2.8.0</common.io.version>
@@ -272,6 +273,16 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>${surefire-plugin.version}</version>
+                <configuration>
+                    <!--                    <argLine>-->
+                    <!--                        -Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${google.errorprone.javac.version}/javac-${google.errorprone.javac.version}.jar-->
+                    <!--                    </argLine>-->
+                    <trimStackTrace>false</trimStackTrace>
+                </configuration>
+            </plugin>
         </plugins>
         <extensions>
             <extension>

larky/src/main/java/com/verygood/security/larky/modules/CodecsModule.java

@@ -2,6 +2,7 @@
 
 import com.verygood.security.larky.modules.codecs.TextUtil;
 import com.verygood.security.larky.modules.types.LarkyByte;
+import com.verygood.security.larky.modules.types.LarkyByteLike;
 
 import net.starlark.java.annot.Param;
 import net.starlark.java.annot.ParamType;
@@ -16,7 +17,9 @@
 import java.nio.CharBuffer;
 import java.nio.charset.CharacterCodingException;
 import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
 import java.nio.charset.CharsetEncoder;
+import java.nio.charset.StandardCharsets;
 
 
 @StarlarkBuiltin(
@@ -26,6 +29,7 @@
 public class CodecsModule implements StarlarkValue {
 
   public static final CodecsModule INSTANCE = new CodecsModule();
+  private static final String UTF8 = StandardCharsets.UTF_8.toString().toLowerCase();
 
   @StarlarkMethod(
       name = "encode",
@@ -88,7 +92,7 @@ public LarkyByte encode(String strToEncode, String encoding, String errors, Star
           @Param(
               name = "obj",
               allowedTypes = {
-                  @ParamType(type = LarkyByte.class),
+                  @ParamType(type = LarkyByteLike.class),
               }
           ),
           @Param(
@@ -109,7 +113,20 @@ public LarkyByte encode(String strToEncode, String encoding, String errors, Star
           )
       }
   )
-  public String decode(LarkyByte bytesToDecode, String encoding, String errors) {
+  public String decode(LarkyByteLike bytesToDecode, String encoding, String errors) throws EvalException {
+    if(CodecsModule.UTF8.equals(encoding.toLowerCase())) {
       return TextUtil.starlarkDecodeUtf8(bytesToDecode.getBytes());
+    }
+    CharsetDecoder decoder = Charset.forName(encoding)
+        .newDecoder()
+        .onMalformedInput(TextUtil.CodecHelper.convertCodingErrorAction(errors))
+        .onUnmappableCharacter(TextUtil.CodecHelper.convertCodingErrorAction(errors));
+    CharBuffer decoded;
+    try {
+      decoded = decoder.decode(ByteBuffer.wrap(bytesToDecode.getBytes()));
+    } catch (CharacterCodingException e) {
+      throw Starlark.errorf(e.getMessage());
+    }
+    return decoded.toString();
   }
 }

larky/src/main/java/com/verygood/security/larky/modules/CryptoModule.java

@@ -16,7 +16,6 @@
 
 import org.bouncycastle.jce.provider.BouncyCastleProvider;
 
-import java.security.Provider;
 import java.security.Security;
 
 
@@ -45,11 +44,7 @@ public class CryptoModule implements StarlarkValue {
      */
     Security.addProvider(new BouncyCastleProvider());
     /* uncomment the below line for a post-quantum provider */
-    // Security.addProvider(new BouncyCastlePQCProvider());
-    Provider[] providers = Security.getProviders();
-    for (int i = 0; i != providers.length; i++) {
-      System.out.println("Name: " + providers[i].getName() + " Version: " + providers[i].getVersion());
-    }
+    //    Security.addProvider(new BouncyCastlePQCProvider());
   }
 
   public static final CryptoModule INSTANCE = new CryptoModule();

larky/src/main/java/com/verygood/security/larky/modules/crypto/CryptoMathModule.java

@@ -28,7 +28,11 @@ public class CryptoMathModule implements StarlarkValue {
   private static final BigInteger MAX_LONG = BigInteger.valueOf(Long.MAX_VALUE);
 
   @StarlarkMethod(name = "jacobi_number",
-       doc = "jacobi number",
+       doc = "Computes Jacobi(p,n).\n" +
+           " Assumes n positive, odd, n>=3.\n" +
+           " Compute the jacobi symbol <code>(a/n)</code>, as described in:\n" +
+           " <a href=\"http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf\">Digital signature standard (DSS). FIPS PUB 186-4, National Institute of Standards and\n" +
+           " Technology (NIST), 2013.</a>, pp. 76-77",
        parameters = {
            @Param(name = "a", allowedTypes = {@ParamType(type = StarlarkInt.class)}),
            @Param(name = "n", allowedTypes = {@ParamType(type = StarlarkInt.class)}),