Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDL requires Docker images on dockerhub #1

Open
edawson opened this issue Jan 30, 2019 · 9 comments
Open

WDL requires Docker images on dockerhub #1

edawson opened this issue Jan 30, 2019 · 9 comments

Comments

@edawson
Copy link
Collaborator

edawson commented Jan 30, 2019

WDL (at least as currently in FireCloud) requires Docker images to be pulled from Dockerhub; Quay and other repositories are not supported.

@mlin would it be possible to tweak the build.sh script in vg_docker to do a:

docker login # logs into dockerhub
docker push docker push "${image_release_with_tag}"

at the end of the build.sh script?

@mlin
Copy link
Member

mlin commented Jan 30, 2019

Dang, yeah, I don't see any blocker to creating a vgteam docker hub account and pushing the image there too. Quay has a much nicer web UI for perusing the available images but if we push to both from CI then I don't see much risk from having the mirror. @adamnovak @glennhickey any comments?

@glennhickey
Copy link

glennhickey commented Jan 30, 2019 via email

@adamnovak
Copy link
Member

adamnovak commented Jan 30, 2019 via email

@mlin
Copy link
Member

mlin commented Jan 31, 2019

Sadness: the "vgteam" docker hub namespace is taken by an esports company...

@edawson
Copy link
Collaborator Author

edawson commented Jan 31, 2019

: (

I own "variantgraphs," and naturally it belongs to the one true vgteam.

@mlin
Copy link
Member

mlin commented Jan 31, 2019

I'm happy to use that. I'm dnamlin on docker hub, can you add me and i'll see what the credentials situation is?

@edawson
Copy link
Collaborator Author

edawson commented Feb 4, 2019

Just added you to the org - sorry for the delay!

@mlin
Copy link
Member

mlin commented Feb 4, 2019

Docker Hub doesn't seem to have the feature of limited API/robot keys, so to avoid having vgteam/vg_docker login in the guise of one of us personally (with full access to our other, unrelated repositories on docker hub), we will have to create a dedicated Docker Hub account for that purpose

@mlin
Copy link
Member

mlin commented Feb 5, 2019

Alright, we should now be set so that whenever @adamnovak cuts a point release of vg, the image will be mirrored to docker hub as well. vgteam/vg_docker#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants