Skip to content

Commit e1875d6

Browse files
authored
APP-6153 pass StartBuildRequest.Token from CLI (#4420)
1 parent 64ff8c7 commit e1875d6

File tree

4 files changed

+21
-18
lines changed

4 files changed

+21
-18
lines changed

cli/app.go

+5
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ const (
6060
moduleBuildFlagBuildID = "id"
6161
moduleBuildFlagPlatform = "platform"
6262
moduleBuildFlagWait = "wait"
63+
moduleBuildFlagToken = "token"
6364
moduleBuildFlagGroupLogs = "group-logs"
6465
moduleBuildRestartOnly = "restart-only"
6566
moduleBuildFlagNoBuild = "no-build"
@@ -1624,6 +1625,10 @@ Example:
16241625
Usage: "git ref to clone when building your module. This can be a branch name or a commit hash",
16251626
Value: "main",
16261627
},
1628+
&cli.StringFlag{
1629+
Name: moduleBuildFlagToken,
1630+
Usage: "checkout token for private repos, not necessary for public repos",
1631+
},
16271632
},
16281633
Action: ModuleBuildStartAction,
16291634
},

cli/module_build.go

+13-15
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,19 @@ func (c *viamClient) moduleBuildStartAction(cCtx *cli.Context) error {
7777
}
7878

7979
gitRef := cCtx.String(moduleBuildFlagRef)
80-
res, err := c.startBuild(manifest.URL, gitRef, manifest.ModuleID, platforms, version)
80+
token := cCtx.String(moduleBuildFlagToken)
81+
req := buildpb.StartBuildRequest{
82+
Repo: manifest.URL,
83+
Ref: &gitRef,
84+
Platforms: platforms,
85+
ModuleId: manifest.ModuleID,
86+
ModuleVersion: version,
87+
Token: &token,
88+
}
89+
if err := c.ensureLoggedIn(); err != nil {
90+
return err
91+
}
92+
res, err := c.buildClient.StartBuild(c.c.Context, &req)
8193
if err != nil {
8294
return err
8395
}
@@ -315,20 +327,6 @@ func ModuleBuildLinkRepoAction(c *cli.Context) error {
315327
return nil
316328
}
317329

318-
func (c *viamClient) startBuild(repo, ref, moduleID string, platforms []string, version string) (*buildpb.StartBuildResponse, error) {
319-
if err := c.ensureLoggedIn(); err != nil {
320-
return nil, err
321-
}
322-
req := buildpb.StartBuildRequest{
323-
Repo: repo,
324-
Ref: &ref,
325-
Platforms: platforms,
326-
ModuleId: moduleID,
327-
ModuleVersion: version,
328-
}
329-
return c.buildClient.StartBuild(c.c.Context, &req)
330-
}
331-
332330
func (c *viamClient) printModuleBuildLogs(buildID, platform string) error {
333331
if err := c.ensureLoggedIn(); err != nil {
334332
return err

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ require (
8383
go.uber.org/atomic v1.11.0
8484
go.uber.org/multierr v1.11.0
8585
go.uber.org/zap v1.24.0
86-
go.viam.com/api v0.1.344
86+
go.viam.com/api v0.1.345
8787
go.viam.com/test v1.1.1-0.20220913152726-5da9916c08a2
8888
go.viam.com/utils v0.1.103
8989
goji.io v2.0.2+incompatible

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -1607,8 +1607,8 @@ go.uber.org/zap v1.18.1/go.mod h1:xg/QME4nWcxGxrpdeYfq7UvYrLh66cuVKdrbD1XF/NI=
16071607
go.uber.org/zap v1.23.0/go.mod h1:D+nX8jyLsMHMYrln8A0rJjFt/T/9/bGgIhAqxv5URuY=
16081608
go.uber.org/zap v1.24.0 h1:FiJd5l1UOLj0wCgbSE0rwwXHzEdAZS6hiiSnxJN/D60=
16091609
go.uber.org/zap v1.24.0/go.mod h1:2kMP+WWQ8aoFoedH3T2sq6iJ2yDWpHbP0f6MQbS9Gkg=
1610-
go.viam.com/api v0.1.344 h1:sfeHBoOA2QfD5S/LKdFJkO17hQeVU+wxBDOCua1Ndag=
1611-
go.viam.com/api v0.1.344/go.mod h1:5lpVRxMsKFCaahqsnJfPGwJ9baoQ6PIKQu3lxvy6Wtw=
1610+
go.viam.com/api v0.1.345 h1:QE7KWhkgIpclAG/aJSI3kIi6Mu5bLhutgrTLCy+QzfI=
1611+
go.viam.com/api v0.1.345/go.mod h1:5lpVRxMsKFCaahqsnJfPGwJ9baoQ6PIKQu3lxvy6Wtw=
16121612
go.viam.com/test v1.1.1-0.20220913152726-5da9916c08a2 h1:oBiK580EnEIzgFLU4lHOXmGAE3MxnVbeR7s1wp/F3Ps=
16131613
go.viam.com/test v1.1.1-0.20220913152726-5da9916c08a2/go.mod h1:XM0tej6riszsiNLT16uoyq1YjuYPWlRBweTPRDanIts=
16141614
go.viam.com/utils v0.1.103 h1:Nqx2TxwpR3RKA5Iy1xKgomq0ASU+DEsHSEdi3w7/KR4=

0 commit comments

Comments
 (0)