From 5b3a1bffccab9672f35b9b9667f087ad38718f0c Mon Sep 17 00:00:00 2001 From: martha-johnston Date: Wed, 29 Jan 2025 18:34:15 +0100 Subject: [PATCH] fix discoverResources --- lib/src/services/discovery.dart | 6 +++--- test/unit_test/services/discovery_test.dart | 6 ++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/src/services/discovery.dart b/lib/src/services/discovery.dart index 3c53c8d4ac..ea17bc2ddd 100644 --- a/lib/src/services/discovery.dart +++ b/lib/src/services/discovery.dart @@ -1,10 +1,10 @@ import 'package:grpc/grpc_connection_interface.dart'; import '../../protos/common/common.dart'; -import '../gen/common/v1/common.pb.dart'; import '../../protos/service/discovery.dart'; -import '../gen/service/discovery/v1/discovery.pbgrpc.dart'; import '../gen/app/v1/robot.pb.dart'; +import '../gen/common/v1/common.pb.dart'; +import '../gen/service/discovery/v1/discovery.pbgrpc.dart'; import '../resource/base.dart'; import '../robot/client.dart'; import '../utils.dart'; @@ -30,7 +30,7 @@ class DiscoveryClient extends Resource implements ResourceRPCClient { /// // Example: /// var resources = await myDiscoveryService.discoverResources('myWebcam'); /// ``` - Future> discoverResources(String discoveryName, {Map? extra}) async { + Future> discoverResources({Map? extra}) async { final request = DiscoverResourcesRequest(name: name, extra: extra?.toStruct()); final response = await client.discoverResources(request); return response.discoveries; diff --git a/test/unit_test/services/discovery_test.dart b/test/unit_test/services/discovery_test.dart index 91039e9017..e95a488ce9 100644 --- a/test/unit_test/services/discovery_test.dart +++ b/test/unit_test/services/discovery_test.dart @@ -1,11 +1,9 @@ -import 'package:fixnum/fixnum.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:mockito/mockito.dart'; import 'package:viam_sdk/protos/service/discovery.dart'; -import 'package:viam_sdk/src/gen/common/v1/common.pb.dart'; +import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart'; import 'package:viam_sdk/src/gen/service/discovery/v1/discovery.pbgrpc.dart'; import 'package:viam_sdk/viam_sdk.dart'; -import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart'; import '../mocks/mock_response_future.dart'; import '../mocks/service_clients_mocks.mocks.dart'; @@ -33,7 +31,7 @@ void main() { final expected = [ComponentConfig()]; when(serviceClient.discoverResources(any)) .thenAnswer((_) => MockResponseFuture.value(DiscoverResourcesResponse(discoveries: expected))); - final response = await client.discoverResources('discoveryName'); + final response = await client.discoverResources(); expect(response, equals(expected)); }); });