Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable authentication in development environments #47

Open
Robin5605 opened this issue Jun 12, 2024 · 0 comments · May be fixed by #48
Open

Disable authentication in development environments #47

Robin5605 opened this issue Jun 12, 2024 · 0 comments · May be fixed by #48
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Robin5605
Copy link
Contributor

Mainframe disables authentication in development like so:

https://github.com/vipyrsec/dragonfly-mainframe/blob/aed89d96021eeb49b4bbc44d5fa1cfc9ea83ebbf/src/mainframe/server.py#L130-L131

I think similarly, authentication should be disabled if a GIT_SHA is not detected or is set to "development"/"testing"

@Robin5605 Robin5605 added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2024
@ShakyaMajumdar ShakyaMajumdar linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant