External Crates Exposed in our library

[DGonzalezVillal]

As @mkulke pointed out, we have types external to our crate that are exposed publicly. Using cargo-check-external-types, I generated a list of these types. I’m sharing it here to start a discussion on how to handle them.

For example, error types could be replaced with strings, but things like Serialize and Deserialize aren’t as straightforward — we may need to consider keeping those exposed.

Here’s the list:

Crate	Type	Used In
bincode	bincode::error::ErrorKind	src/error.rs:1003:18
bincode	bincode::error::ErrorKind	src/error.rs:1098:1
bincode	bincode::error::ErrorKind	src/error.rs:725:18
bincode	bincode::error::ErrorKind	src/error.rs:754:1
bincode	bincode::error::ErrorKind	src/error.rs:929:18
bincode	bincode::error::ErrorKind	src/error.rs:981:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::IterNames	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:250:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:396:1
bitflags	bitflags::iter::IterNames	src/launch/snp.rs:222:1
bitflags	bitflags::traits::Flags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::Flags	src/launch/snp.rs:222:1
bitflags	bitflags::traits::PublicFlags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::PublicFlags	src/launch/snp.rs:222:1
codicon	codicon::Decoder	src/certs/sev/ca/cert/mod.rs:84:1
codicon	codicon::Decoder	src/certs/sev/ca/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/sev/cert/mod.rs:75:1
codicon	codicon::Decoder	src/certs/sev/sev/chain.rs:26:1
codicon	codicon::Decoder	src/firmware/host/types/sev.rs:80:1
codicon	codicon::Decoder	src/launch/sev.rs:380:1
codicon	codicon::Decoder	src/launch/sev.rs:457:1
codicon	codicon::Decoder	src/launch/sev.rs:488:1
codicon	codicon::Decoder	src/vmsa/mod.rs:307:1
codicon	codicon::Encoder	src/certs/sev/ca/cert/mod.rs:97:1
codicon	codicon::Encoder	src/certs/sev/ca/chain.rs:38:1
codicon	codicon::Encoder	src/certs/sev/chain.rs:30:1
codicon	codicon::Encoder	src/certs/sev/sev/cert/mod.rs:88:1
codicon	codicon::Encoder	src/certs/sev/sev/chain.rs:54:1
codicon	codicon::Encoder	src/firmware/host/types/sev.rs:88:1
codicon	codicon::Encoder	src/launch/sev.rs:388:1
codicon	codicon::Encoder	src/launch/sev.rs:468:1
codicon	codicon::Encoder	src/launch/sev.rs:496:1
codicon	codicon::Encoder	src/vmsa/mod.rs:315:1
hex	hex::error::FromHexError	src/error.rs:1009:18
hex	hex::error::FromHexError	src/error.rs:1110:1
serde	serde::de::Deserialize	src/certs/sev/ca/cert/mod.rs:120:1
serde	serde::de::Deserialize	src/certs/sev/ca/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/sev/cert/mod.rs:111:1
serde	serde::de::Deserialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:32
serde	serde::de::Deserialize	src/certs/sev/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/snp/ecdsa/mod.rs:20:32
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:128:30
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:229:39
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:791:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:907:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:996:14
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:116:30
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:39:82
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:65:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:155:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:459:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:50:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:566:53
serde	serde::de::Deserialize	src/launch/sev.rs:304:1
serde	serde::de::Deserialize	src/launch/sev.rs:318:54
serde	serde::de::Deserialize	src/launch/sev.rs:344:56
serde	serde::de::Deserialize	src/launch/sev.rs:368:45
serde	serde::de::Deserialize	src/launch/sev.rs:419:1
serde	serde::de::Deserialize	src/launch/sev.rs:433:45
serde	serde::de::Deserialize	src/launch/sev.rs:448:39
serde	serde::de::Deserialize	src/launch/sev.rs:479:45
serde	serde::de::Deserialize	src/launch/snp.rs:150:48
serde	serde::de::Deserialize	src/launch/snp.rs:175:45
serde	serde::de::Deserialize	src/launch/snp.rs:199:45
serde	serde::de::Deserialize	src/launch/snp.rs:249:1
serde	serde::de::Deserialize	src/vmsa/mod.rs:52:30
serde	serde::de::Deserialize	src/vmsa/mod.rs:73:43
serde	serde::ser::Serialize	src/certs/sev/ca/cert/mod.rs:132:1
serde	serde::ser::Serialize	src/certs/sev/ca/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/sev/cert/mod.rs:123:1
serde	serde::ser::Serialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:45
serde	serde::ser::Serialize	src/certs/sev/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/snp/ecdsa/mod.rs:20:45
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:128:43
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:229:52
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:791:55
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:907:40
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:996:72
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:116:19
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:39:71
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:65:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:155:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:459:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:50:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:566:42
serde	serde::ser::Serialize	src/launch/sev.rs:276:1
serde	serde::ser::Serialize	src/launch/sev.rs:318:67
serde	serde::ser::Serialize	src/launch/sev.rs:344:45
serde	serde::ser::Serialize	src/launch/sev.rs:368:58
serde	serde::ser::Serialize	src/launch/sev.rs:406:1
serde	serde::ser::Serialize	src/launch/sev.rs:433:58
serde	serde::ser::Serialize	src/launch/sev.rs:448:52
serde	serde::ser::Serialize	src/launch/sev.rs:479:58
serde	serde::ser::Serialize	src/launch/snp.rs:150:61
serde	serde::ser::Serialize	src/launch/snp.rs:175:58
serde	serde::ser::Serialize	src/launch/snp.rs:199:58
serde	serde::ser::Serialize	src/launch/snp.rs:240:1
serde	serde::ser::Serialize	src/vmsa/mod.rs:52:19
serde	serde::ser::Serialize	src/vmsa/mod.rs:73:32
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:107:1
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:178:5
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:73:11
uuid	uuid::error::Error	src/error.rs:1000:15
uuid	uuid::error::Error	src/error.rs:1092:1
uuid	uuid::error::Error	src/error.rs:531:15
uuid	uuid::error::Error	src/error.rs:593:1
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:108:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:178:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:93:5

[DGonzalezVillal]

With OPENSSL enabled:

Crate	Type	Used In
bincode	bincode::error::ErrorKind	src/error.rs:1003:18
bincode	bincode::error::ErrorKind	src/error.rs:1098:1
bincode	bincode::error::ErrorKind	src/error.rs:725:18
bincode	bincode::error::ErrorKind	src/error.rs:754:1
bincode	bincode::error::ErrorKind	src/error.rs:929:18
bincode	bincode::error::ErrorKind	src/error.rs:981:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRange	src/measurement/vmsa.rs:112:1
bitfield	bitfield::BitRange	src/measurement/vmsa.rs:112:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/measurement/vmsa.rs:112:1
bitfield	bitfield::BitRangeMut	src/measurement/vmsa.rs:112:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::IterNames	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:250:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:396:1
bitflags	bitflags::iter::IterNames	src/launch/snp.rs:222:1
bitflags	bitflags::traits::Flags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::Flags	src/launch/snp.rs:222:1
bitflags	bitflags::traits::PublicFlags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::PublicFlags	src/launch/snp.rs:222:1
codicon	codicon::Decoder	src/certs/sev/ca/cert/mod.rs:84:1
codicon	codicon::Decoder	src/certs/sev/ca/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/crypto.rs:45:1
codicon	codicon::Decoder	src/certs/sev/crypto.rs:45:1
codicon	codicon::Decoder	src/certs/sev/crypto.rs:45:1
codicon	codicon::Decoder	src/certs/sev/sev/cert/mod.rs:75:1
codicon	codicon::Decoder	src/certs/sev/sev/chain.rs:26:1
codicon	codicon::Decoder	src/firmware/host/types/sev.rs:80:1
codicon	codicon::Decoder	src/launch/sev.rs:380:1
codicon	codicon::Decoder	src/launch/sev.rs:457:1
codicon	codicon::Decoder	src/launch/sev.rs:488:1
codicon	codicon::Decoder	src/vmsa/mod.rs:307:1
codicon	codicon::Encoder	src/certs/sev/ca/cert/mod.rs:109:1
codicon	codicon::Encoder	src/certs/sev/ca/cert/mod.rs:97:1
codicon	codicon::Encoder	src/certs/sev/ca/chain.rs:38:1
codicon	codicon::Encoder	src/certs/sev/chain.rs:30:1
codicon	codicon::Encoder	src/certs/sev/crypto.rs:50:1
codicon	codicon::Encoder	src/certs/sev/sev/cert/mod.rs:100:1
codicon	codicon::Encoder	src/certs/sev/sev/cert/mod.rs:88:1
codicon	codicon::Encoder	src/certs/sev/sev/chain.rs:54:1
codicon	codicon::Encoder	src/firmware/host/types/sev.rs:88:1
codicon	codicon::Encoder	src/launch/sev.rs:388:1
codicon	codicon::Encoder	src/launch/sev.rs:468:1
codicon	codicon::Encoder	src/launch/sev.rs:496:1
codicon	codicon::Encoder	src/vmsa/mod.rs:315:1
hex	hex::error::FromHexError	src/error.rs:1009:18
hex	hex::error::FromHexError	src/error.rs:1110:1
openssl	openssl::ec::EcKey	src/measurement/idblock.rs:82:1
openssl	openssl::ec::EcKey	src/measurement/idblock_types.rs:151:1
openssl	openssl::ec::EcKey	src/measurement/idblock_types.rs:77:1
openssl	openssl::ecdsa::EcdsaSig	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:56:1
openssl	openssl::ecdsa::EcdsaSig	src/certs/snp/ecdsa/mod.rs:99:1
openssl	openssl::error::ErrorStack	src/error.rs:1154:18
openssl	openssl::error::ErrorStack	src/error.rs:1175:1
openssl	openssl::error::ErrorStack	src/error.rs:920:22
openssl	openssl::error::ErrorStack	src/error.rs:963:1
openssl	openssl::pkey::PKey	src/certs/snp/cert.rs:124:5
openssl	openssl::pkey::Private	src/measurement/idblock.rs:82:1
openssl	openssl::pkey::Private	src/measurement/idblock_types.rs:151:1
openssl	openssl::pkey::Private	src/measurement/idblock_types.rs:77:1
openssl	openssl::pkey::Public	src/certs/snp/cert.rs:124:5
openssl	openssl::x509::X509	src/certs/snp/ca/mod.rs:35:1
openssl	openssl::x509::X509	src/certs/snp/ca/mod.rs:46:1
openssl	openssl::x509::X509	src/certs/snp/ca/mod.rs:62:1
openssl	openssl::x509::X509	src/certs/snp/cert.rs:42:1
openssl	openssl::x509::X509	src/certs/snp/cert.rs:62:1
openssl	openssl::x509::X509	src/certs/snp/cert.rs:68:1
openssl	openssl::x509::X509	src/certs/snp/chain.rs:45:1
openssl	openssl::x509::X509	src/certs/snp/chain.rs:71:1
rdrand	rdrand::errors::ErrorCode	src/error.rs:1151:15
rdrand	rdrand::errors::ErrorCode	src/error.rs:1161:1
rdrand	rdrand::errors::ErrorCode	src/session/mod.rs:50:5
rdrand	rdrand::errors::ErrorCode	src/session/mod.rs:50:5
serde	serde::de::Deserialize	src/certs/sev/ca/cert/mod.rs:120:1
serde	serde::de::Deserialize	src/certs/sev/ca/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/sev/cert/mod.rs:111:1
serde	serde::de::Deserialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:32
serde	serde::de::Deserialize	src/certs/sev/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/snp/ecdsa/mod.rs:20:32
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:128:30
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:229:39
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:791:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:907:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:996:14
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:116:30
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:39:82
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:65:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:155:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:459:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:50:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:566:53
serde	serde::de::Deserialize	src/launch/sev.rs:304:1
serde	serde::de::Deserialize	src/launch/sev.rs:318:54
serde	serde::de::Deserialize	src/launch/sev.rs:344:56
serde	serde::de::Deserialize	src/launch/sev.rs:368:45
serde	serde::de::Deserialize	src/launch/sev.rs:419:1
serde	serde::de::Deserialize	src/launch/sev.rs:433:45
serde	serde::de::Deserialize	src/launch/sev.rs:448:39
serde	serde::de::Deserialize	src/launch/sev.rs:479:45
serde	serde::de::Deserialize	src/launch/snp.rs:150:48
serde	serde::de::Deserialize	src/launch/snp.rs:175:45
serde	serde::de::Deserialize	src/launch/snp.rs:199:45
serde	serde::de::Deserialize	src/launch/snp.rs:249:1
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:131:30
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:142:30
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:198:21
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:262:21
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:44:30
serde	serde::de::Deserialize	src/measurement/idblock_types.rs:69:30
serde	serde::de::Deserialize	src/measurement/ovmf.rs:27:41
serde	serde::de::Deserialize	src/measurement/ovmf.rs:74:30
serde	serde::de::Deserialize	src/measurement/snp.rs:29:37
serde	serde::de::Deserialize	src/measurement/vmsa.rs:133:53
serde	serde::de::Deserialize	src/vmsa/mod.rs:52:30
serde	serde::de::Deserialize	src/vmsa/mod.rs:73:43
serde	serde::ser::Serialize	src/certs/sev/ca/cert/mod.rs:132:1
serde	serde::ser::Serialize	src/certs/sev/ca/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/sev/cert/mod.rs:123:1
serde	serde::ser::Serialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:45
serde	serde::ser::Serialize	src/certs/sev/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/snp/ecdsa/mod.rs:20:45
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:128:43
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:229:52
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:791:55
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:907:40
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:996:72
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:116:19
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:39:71
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:65:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:155:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:459:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:50:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:566:42
serde	serde::ser::Serialize	src/launch/sev.rs:276:1
serde	serde::ser::Serialize	src/launch/sev.rs:318:67
serde	serde::ser::Serialize	src/launch/sev.rs:344:45
serde	serde::ser::Serialize	src/launch/sev.rs:368:58
serde	serde::ser::Serialize	src/launch/sev.rs:406:1
serde	serde::ser::Serialize	src/launch/sev.rs:433:58
serde	serde::ser::Serialize	src/launch/sev.rs:448:52
serde	serde::ser::Serialize	src/launch/sev.rs:479:58
serde	serde::ser::Serialize	src/launch/snp.rs:150:61
serde	serde::ser::Serialize	src/launch/snp.rs:175:58
serde	serde::ser::Serialize	src/launch/snp.rs:199:58
serde	serde::ser::Serialize	src/launch/snp.rs:240:1
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:131:19
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:142:19
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:198:10
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:262:10
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:44:19
serde	serde::ser::Serialize	src/measurement/idblock_types.rs:69:19
serde	serde::ser::Serialize	src/measurement/snp.rs:29:26
serde	serde::ser::Serialize	src/measurement/vmsa.rs:133:42
serde	serde::ser::Serialize	src/vmsa/mod.rs:52:19
serde	serde::ser::Serialize	src/vmsa/mod.rs:73:32
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:107:1
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:178:5
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:73:11
uuid	uuid::error::Error	src/error.rs:1000:15
uuid	uuid::error::Error	src/error.rs:1092:1
uuid	uuid::error::Error	src/error.rs:531:15
uuid	uuid::error::Error	src/error.rs:593:1
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:108:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:178:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:93:5

[DGonzalezVillal]

crypto_nossl:

Crate	Type	Used In
bincode	bincode::error::ErrorKind	src/error.rs:1003:18
bincode	bincode::error::ErrorKind	src/error.rs:1098:1
bincode	bincode::error::ErrorKind	src/error.rs:725:18
bincode	bincode::error::ErrorKind	src/error.rs:754:1
bincode	bincode::error::ErrorKind	src/error.rs:929:18
bincode	bincode::error::ErrorKind	src/error.rs:981:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRange	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:765:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:894:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:95:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/guest/types/snp.rs:985:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:228:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:31:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:558:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitfield	bitfield::BitRangeMut	src/firmware/host/types/snp.rs:612:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:250:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/sev.rs:396:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::Iter	src/launch/snp.rs:222:1
bitflags	bitflags::iter::IterNames	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:250:1
bitflags	bitflags::iter::IterNames	src/launch/sev.rs:396:1
bitflags	bitflags::iter::IterNames	src/launch/snp.rs:222:1
bitflags	bitflags::traits::Flags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::Flags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::Flags	src/launch/snp.rs:222:1
bitflags	bitflags::traits::PublicFlags	src/firmware/linux/host/types/sev.rs:11:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:250:1
bitflags	bitflags::traits::PublicFlags	src/launch/sev.rs:396:1
bitflags	bitflags::traits::PublicFlags	src/launch/snp.rs:222:1
codicon	codicon::Decoder	src/certs/sev/ca/cert/mod.rs:84:1
codicon	codicon::Decoder	src/certs/sev/ca/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/chain.rs:20:1
codicon	codicon::Decoder	src/certs/sev/sev/cert/mod.rs:75:1
codicon	codicon::Decoder	src/certs/sev/sev/chain.rs:26:1
codicon	codicon::Decoder	src/firmware/host/types/sev.rs:80:1
codicon	codicon::Decoder	src/launch/sev.rs:380:1
codicon	codicon::Decoder	src/launch/sev.rs:457:1
codicon	codicon::Decoder	src/launch/sev.rs:488:1
codicon	codicon::Decoder	src/vmsa/mod.rs:307:1
codicon	codicon::Encoder	src/certs/sev/ca/cert/mod.rs:97:1
codicon	codicon::Encoder	src/certs/sev/ca/chain.rs:38:1
codicon	codicon::Encoder	src/certs/sev/chain.rs:30:1
codicon	codicon::Encoder	src/certs/sev/sev/cert/mod.rs:88:1
codicon	codicon::Encoder	src/certs/sev/sev/chain.rs:54:1
codicon	codicon::Encoder	src/firmware/host/types/sev.rs:88:1
codicon	codicon::Encoder	src/launch/sev.rs:388:1
codicon	codicon::Encoder	src/launch/sev.rs:468:1
codicon	codicon::Encoder	src/launch/sev.rs:496:1
codicon	codicon::Encoder	src/vmsa/mod.rs:315:1
hex	hex::error::FromHexError	src/error.rs:1009:18
hex	hex::error::FromHexError	src/error.rs:1110:1
serde	serde::de::Deserialize	src/certs/sev/ca/cert/mod.rs:120:1
serde	serde::de::Deserialize	src/certs/sev/ca/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/sev/sev/cert/mod.rs:111:1
serde	serde::de::Deserialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:32
serde	serde::de::Deserialize	src/certs/sev/sev/chain.rs:11:32
serde	serde::de::Deserialize	src/certs/snp/ecdsa/mod.rs:20:32
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:128:30
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:229:39
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:791:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:907:14
serde	serde::de::Deserialize	src/firmware/guest/types/snp.rs:996:14
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:116:30
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:39:82
serde	serde::de::Deserialize	src/firmware/host/types/sev.rs:65:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:155:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:459:82
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:50:39
serde	serde::de::Deserialize	src/firmware/host/types/snp.rs:566:53
serde	serde::de::Deserialize	src/launch/sev.rs:304:1
serde	serde::de::Deserialize	src/launch/sev.rs:318:54
serde	serde::de::Deserialize	src/launch/sev.rs:344:56
serde	serde::de::Deserialize	src/launch/sev.rs:368:45
serde	serde::de::Deserialize	src/launch/sev.rs:419:1
serde	serde::de::Deserialize	src/launch/sev.rs:433:45
serde	serde::de::Deserialize	src/launch/sev.rs:448:39
serde	serde::de::Deserialize	src/launch/sev.rs:479:45
serde	serde::de::Deserialize	src/launch/snp.rs:150:48
serde	serde::de::Deserialize	src/launch/snp.rs:175:45
serde	serde::de::Deserialize	src/launch/snp.rs:199:45
serde	serde::de::Deserialize	src/launch/snp.rs:249:1
serde	serde::de::Deserialize	src/vmsa/mod.rs:52:30
serde	serde::de::Deserialize	src/vmsa/mod.rs:73:43
serde	serde::ser::Serialize	src/certs/sev/ca/cert/mod.rs:132:1
serde	serde::ser::Serialize	src/certs/sev/ca/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/sev/sev/cert/mod.rs:123:1
serde	serde::ser::Serialize	src/certs/sev/sev/cert/v1/sig/ecdsa.rs:14:45
serde	serde::ser::Serialize	src/certs/sev/sev/chain.rs:11:45
serde	serde::ser::Serialize	src/certs/snp/ecdsa/mod.rs:20:45
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:128:43
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:229:52
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:791:55
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:907:40
serde	serde::ser::Serialize	src/firmware/guest/types/snp.rs:996:72
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:116:19
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:39:71
serde	serde::ser::Serialize	src/firmware/host/types/sev.rs:65:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:155:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:459:71
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:50:52
serde	serde::ser::Serialize	src/firmware/host/types/snp.rs:566:42
serde	serde::ser::Serialize	src/launch/sev.rs:276:1
serde	serde::ser::Serialize	src/launch/sev.rs:318:67
serde	serde::ser::Serialize	src/launch/sev.rs:344:45
serde	serde::ser::Serialize	src/launch/sev.rs:368:58
serde	serde::ser::Serialize	src/launch/sev.rs:406:1
serde	serde::ser::Serialize	src/launch/sev.rs:433:58
serde	serde::ser::Serialize	src/launch/sev.rs:448:52
serde	serde::ser::Serialize	src/launch/sev.rs:479:58
serde	serde::ser::Serialize	src/launch/snp.rs:150:61
serde	serde::ser::Serialize	src/launch/snp.rs:175:58
serde	serde::ser::Serialize	src/launch/snp.rs:199:58
serde	serde::ser::Serialize	src/launch/snp.rs:240:1
serde	serde::ser::Serialize	src/vmsa/mod.rs:52:19
serde	serde::ser::Serialize	src/vmsa/mod.rs:73:32
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:107:1
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:178:5
uuid	uuid::Uuid	src/firmware/host/types/snp.rs:73:11
uuid	uuid::error::Error	src/error.rs:1000:15
uuid	uuid::error::Error	src/error.rs:1092:1
uuid	uuid::error::Error	src/error.rs:531:15
uuid	uuid::error::Error	src/error.rs:593:1
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:108:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:178:5
uuid	uuid::error::Error	src/firmware/host/types/snp.rs:93:5

[DGonzalezVillal]

@tylerfanelli @mkulke

From this list it seems to me that:

Crate	Type
bitfield	bitfield::BitRange
bitfield	bitfield::BitRangeMut
serde	serde::de::Deserialize
serde	serde::ser::Serialize
uuid	uuid::Uuid
And also the new Bincode traits Encode and Decode, which had not been added yet when I created these lists.

Will have to be exposed since they're all traits of structures that form part of our public api.

Unless we want to create a public facing structure and an internal one for each one of them, but that seems like too much work.

Thoughts?

[mkulke]

The general rule of thumb is that if something is an implementation detail it shouldn't be exposed.

For example: If the user is expected to use the uuid types or methods on those types, then it should be part of the public signatures.

Glancing over the code usage of uuid, it seems to be used mostly with string constants and otherwise and passed through.

    fn try_from(value: &uuid::Uuid) -> Result<Self, Self::Error> {
        Ok(match value.to_string().as_str() {
            "00000000-0000-0000-0000-000000000000" => CertType::Empty,
            "c0b406a4-a803-4952-9743-3fb6014cd0ae" => CertType::ARK,
            "4ab7b379-bbac-4fe4-a02f-05aef327c782" => CertType::ASK,
            "63da758d-e664-4564-adc5-f4b93be8accd" => CertType::VCEK,
            "a8074bc2-a25a-483e-aae6-39c045a0b8a1" => CertType::VLEK,
            "92f81bc3-5811-4d3d-97ff-d19f88dc67ea" => CertType::CRL,
            _ => CertType::OTHER(*value),
        })
    }

this will always succeed, atm. but what could happen is that this impl, accepts an &str, then on the _ => path it could be verified to be an actual uuid and return an error. In this case uuid wouldn't be exposed.

[tylerfanelli]

@DGonzalezVillal can this issue be closed?

[DGonzalezVillal]

Let me see how this dependency chart currently looks like and we can decide if we want to make further changes.