Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate a shared certificate + auto install it #14

Open
hugoattal opened this issue Dec 14, 2022 · 3 comments
Open

Add option to generate a shared certificate + auto install it #14

hugoattal opened this issue Dec 14, 2022 · 3 comments

Comments

@hugoattal
Copy link
Contributor

hugoattal commented Dec 14, 2022

So after talking a bit with @userquin, I suggest adding two features:

The first time the plugin is launched in a project, as the user where he wants to generate the certificate:

(x) Generate a project scoped certificate
( ) Use a shared certificate

If the user chooses the shared certificate, ask him if he wants to install it

Would you like to install this certificate to your OS? (y/N)

I can work on this feature.

@hugoattal
Copy link
Contributor Author

After thinking about it, I don't think there's any usecase where you might prefer a project scoped certificate compared to a shared certificate 🤔... I mean, the only downside I see is that the certificate may remain somewhere in your system even after you delete all your js projects.

So I think it might be better to just create a shared certificate anyway.

@dominikg
Copy link

sometimes you want to create a local certificate for a custom test domain, not localhost (some features in some browsers only work with the "green ssl lock" and you can't always get that for localhost)
So application specific certificates have a usecase.

Either way you should ensure that
a) the cert is limited in scope as much as possible
b) stored in a secure location with limited access rights to the user only
c) added to the os/browser chains only for ssl purposes and only after user confirmed this is ok
d) if you have to add the root ca to the os chain to achieve "green lock", throw away the key to that CA immediately

The goal of all this is that it is impossible to use this devtool to compromise the developer by getting access to a trusted ca and presenting them with a fake site that looks legit.

@dominikg
Copy link

For a single shared cert on the system, you would have to find a good location, os wide application cache dir for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants