Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue SSR playground scoped style not replaced when HRM #314

Open
8 of 9 tasks
yooouuri opened this issue Dec 18, 2023 · 1 comment
Open
8 of 9 tasks

Vue SSR playground scoped style not replaced when HRM #314

yooouuri opened this issue Dec 18, 2023 · 1 comment
Labels
feat: hmr p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)

Comments

@yooouuri
Copy link

yooouuri commented Dec 18, 2023

Related plugins

Describe the bug

The <style> in App.vue is not scoped.

image

After making the style tag scoped. The old "unscoped" style tag is not replaced.

image

Reproduction

https://github.com/vitejs/vite-plugin-vue/tree/main/playground/ssr-vue

Steps to reproduce

git clone [email protected]:vitejs/vite-plugin-vue.git
cd vite-plugin-vue
pnpm install && pnpm build
cd playground/ssr-vue
pnpm dev

System Info

System:
    OS: macOS 14.2
    CPU: (8) arm64 Apple M1 Pro
    Memory: 174.59 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.11.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Safari: 17.2
  npmPackages:
    @vitejs/plugin-vue: workspace:* => 5.0.0-beta.1 
    @vitejs/plugin-vue-jsx: workspace:* => 3.1.0 
    @vitejs/test-dep-import-type: link:dep-import-type => 0.0.0 
    @vitejs/test-example-external-component: file:example-external-component => 0.0.0

Used Package Manager

pnpm

Logs

No response

Validations

@yooouuri
Copy link
Author

non scoped > scoped, not removing the style by HRM.

scoped > non scoped, the scoped style tag is removed by HRM.

@edison1105 edison1105 added feat: hmr p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) and removed pending triage labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

No branches or pull requests

2 participants