Some errors related to pre-bundled vitest on browser mode on 5.0.0-beta.7

[hi-ogawa]

I was testing beta in standalone repro and found two issues. Likely due to #10713

Reproduction: https://github.com/hi-ogawa/reproductions/tree/main/vitest-10729-browser-locator-optimize

• It fails without vite installed at the project:

~/.local/share/ho-dev-notes/vitest/pr-10729-external-browser-repro $ pnpm test --run
$ vitest run --run

 RUN  v5.0.0-beta.7 /Users/hogawa/.local/share/ho-dev-notes/vitest/pr-10729-external-browser-repro
      API started at http://localhost:63315/

2:50:12 PM [vite] (client) Pre-transform error: Failed to resolve import "vite/module-runner" from "node_modules/.vite/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/deps/index.CLtI1k_4-HUooSsSw.js?v=6667e1ac". Does the file exist?
  Plugin: vite:import-analysis
  File: /Users/hogawa/.local/share/ho-dev-notes/vitest/pr-10729-external-browser-repro/node_modules/.vite/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/deps/index.CLtI1k_4-HUooSsSw.js?v=6667e1ac:5:34
  3  |  import { Bench as $ } from "./tinybench.js";
  4  |  import { $ as getType, A as processError, C as getFn, D as onTestFailed, E as matchesTags, F as test, G as getSafeTim...
  5  |  import { EvaluatedModules } from "vite/module-runner";
     |                                    ^
  6  |  //#region node_modules/.pnpm/vitest@5.0.0-beta.7_@vitest+browser-playwright@5.0.0-beta.7_@vitest+ui@5.0.0-beta.7_vite...
  7  |  var NAME_WORKER_STATE = "__vitest_worker__";
2:50:12 PM [vite] Internal server error: Failed to resolve import "vite/module-runner" from "node_modules/.vite/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/deps/index.CLtI1k_4-HUooSsSw.js?v=6667e1ac". Does the file exist?

• After installing vite, it shows @vitest/browser/client warning on first run.

~/code/personal/reproductions/vitest-10729-browser-locator-optimize $ rm -rf node_modules/.vite
~/code/personal/reproductions/vitest-10729-browser-locator-optimize $ pnpm test
✓ Lockfile passes supply-chain policies (verified 1m ago)
Lockfile is up to date, resolution step is skipped
Already up to date
Done in 226ms using pnpm v11.15.1
$ vitest run
Failed to resolve dependency: @vitest/browser/client, present in client 'optimizeDeps.include'

 RUN  v5.0.0-beta.7 /Users/hogawa/code/personal/reproductions/vitest-10729-browser-locator-optimize
      API started at http://localhost:63315/
...

[sheremet-va]

Not related directly, but vitest is not always bundled into vitest.js:

https://github.com/vitejs/vite-ecosystem-ci/actions/runs/30244368597/job/89908078735

[silvenon]

I got this locally, not sure if it's related, it's failing all my Browser Mode tests:

Error: Failed to import test file /Users/me/Code/my-project/test/browser-setup.ts
Caused by: Error: Vitest failed to find the runner. One of the following is possible:
- "vitest" is imported directly without running "vitest" command
- "vitest" is imported inside "globalSetup" (to fix this, use "setupFiles" instead, because "globalSetup" runs in a different context)
- "vitest" is imported inside Vite / Vitest config file

This file is configured in setupFiles by Browser Mode tests, the only thing I changed since 5.0.0-beta.6 is updating Playwright and Vite to latest, and updating Vitest and @vitest/browser-playwright to latest 5.0.0-beta.7.

[sheremet-va]

I got this locally, not sure if it's related, it's failing all my Browser Mode tests:

Error: Failed to import test file /Users/me/Code/my-project/test/browser-setup.ts
Caused by: Error: Vitest failed to find the runner. One of the following is possible:
- "vitest" is imported directly without running "vitest" command
- "vitest" is imported inside "globalSetup" (to fix this, use "setupFiles" instead, because "globalSetup" runs in a different context)
- "vitest" is imported inside Vite / Vitest config file

This file is configured in setupFiles by Browser Mode tests, the only thing I changed since 5.0.0-beta.6 is updating Playwright and Vite to latest, and updating Vitest and @vitest/browser-playwright to latest 5.0.0-beta.7.

Any reproduction would be nice

[silvenon]

Ah, sorry, here you go: https://github.com/silvenon/repro/tree/vitest-beta-browser-mode-setup-file

I've written a few insights there as I tried to make it more minimal.

gh repo clone silvenon/repro -b vitest-beta-browser-mode-setup-file
cd repro
pnpm install
pnpm test:setup
pnpm test