Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different browsers have different shortcuts and some VZCode shortcuts trigger them #881

Open
IBurntMyBagel opened this issue Nov 26, 2024 · 2 comments

Comments

@IBurntMyBagel
Copy link
Collaborator

This stack overflow post shows how to override most browser shortcuts, and I think we should give it a try to see if it works. https://stackoverflow.com/questions/3680919/overriding-browsers-keyboard-shortcuts

If this works, it would help prevent users from accidentally pressing random shortcuts and allow users to use some shortcuts that they wouldn't have had access to before.
image

@curran
Copy link
Contributor

curran commented Nov 27, 2024

Not a bad idea! Although, the browser shortcuts are nice and people might expect them.

Perhaps we can narrow the focus to specific shortcuts that VZCode has functionality for, which are conflicting with browser shortcuts? I would rather go one-by-one than shotgun the whole thing and risk making the UX worse by removing browser shortcuts that people expect to work.

@IBurntMyBagel
Copy link
Collaborator Author

Oh yeah, we should only override only the shortcuts that the program uses.

I was ensuring all keyboard shortcuts worked when I noticed the issue of conflicting shortcuts. Ex: On Microsoft Edge browser the shortcut for Ctrl + Shift + N opens a new incognito tab instead of the VZCode shortcut bringing up a new file.

I have a branch where I listed some shortcuts to fix. If I have time after the rcos poster, I'll look over this issue into more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants