fix: update test imports and fix linting issues

- Fix import paths from advanced_constraints to constraints package
- Fix line length errors (E501) in test files
- Fix type error for request_start None check
- Update test coverage documentation

Signed-off-by: Alon Kellner <[email protected]>

Author: AlonKellner-RedHat

src/guidellm/scheduler/constraints/over_saturation.py

@@ -367,6 +367,7 @@ def __call__(
             request_info.status == "completed"
             and request_info.timings
             and request_info.timings.first_token_iteration
+            and request_info.timings.request_start
         ):
             ttft = (
                 request_info.timings.first_token_iteration
@@ -446,7 +447,9 @@ def create_constraint(self, **_kwargs) -> Constraint:
         )
 
     @classmethod
-    def validated_kwargs(cls, stop_over_saturated: bool | None = None, **kwargs) -> dict[str, Any]:
+    def validated_kwargs(
+        cls, stop_over_saturated: bool | None = None, **kwargs
+    ) -> dict[str, Any]:
         """
         Validate and process arguments for OverSaturationConstraint creation.
 

tests/unit/scheduler/OVER_SATURATION_TEST_COVERAGE.md

@@ -221,7 +221,7 @@ pytest tests/unit/scheduler/test_over_saturation*.py -m smoke -v
 pytest tests/unit/scheduler/test_over_saturation*.py -m sanity -v
 
 # Run with coverage reporting
-pytest tests/unit/scheduler/test_over_saturation*.py --cov=guidellm.scheduler.advanced_constraints.over_saturation
+pytest tests/unit/scheduler/test_over_saturation*.py --cov=guidellm.scheduler.constraints.over_saturation
 ```
 
 ## Conclusion

tests/unit/scheduler/test_over_saturation.py

@@ -208,7 +208,7 @@ def test_protocol_method_signature(self):
 
     @pytest.mark.smoke
     def test_initialization_valid(self, valid_instances):
-        """Test that OverSaturationConstraint can be initialized with valid parameters."""
+        """Test OverSaturationConstraint initialization with valid parameters."""
         constraint, constructor_args = valid_instances
 
         assert constraint.stop_over_saturated == constructor_args["stop_over_saturated"]
@@ -365,7 +365,7 @@ class TestOverSaturationConstraintInitializer:
         ]
     )
     def valid_instances(self, request):
-        """Create OverSaturationConstraintInitializer instances with valid parameters."""
+        """Create OverSaturationConstraintInitializer with valid parameters."""
         constructor_args = request.param
         instance = OverSaturationConstraintInitializer(**constructor_args)
         return instance, constructor_args
@@ -553,7 +553,7 @@ class TestSlopeChecker:
     @pytest.fixture
     def slope_checker(self):
         """Create a SlopeChecker instance for testing."""
-        from guidellm.scheduler.advanced_constraints.over_saturation import (
+        from guidellm.scheduler.constraints.over_saturation import (
             SlopeChecker,
         )
 

tests/unit/scheduler/test_over_saturation_comprehensive.py

@@ -17,7 +17,7 @@
     SchedulerState,
     SchedulerUpdateAction,
 )
-from guidellm.scheduler.advanced_constraints.over_saturation import (
+from guidellm.scheduler.constraints.over_saturation import (
     SlopeChecker,
     approx_t_ppf,
 )
@@ -411,7 +411,8 @@ def test_constraint_metadata_completeness(self):
             "ttft_slope",
             "ttft_n",
             "ttft_violations",  # Correct field name
-            # Note: total_started_ever, total_finished_ever, window sizes not in metadata
+            # Note: total_started_ever, total_finished_ever,
+            # window sizes not in metadata
         ]
 
         for field in required_fields:
@@ -840,5 +841,6 @@ def test_ttft_violation_counting_accuracy(self):
             detector.add_finished({"ttft": ttft, "duration": float(i)})
 
         assert detector.ttft_violations_counter == expected_violations, (
-            f"Expected {expected_violations} violations, got {detector.ttft_violations_counter}"
+            f"Expected {expected_violations} violations, "
+            f"got {detector.ttft_violations_counter}"
         )