-
Notifications
You must be signed in to change notification settings - Fork 77
Block matmul and kv_cache in dynamic quantization #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Block matmul and kv_cache in dynamic quantization #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR configures dynamic quantization to exclude specific matrix multiplication and key-value cache operations from quantization. The changes prevent quantization of attention mechanism components that may be sensitive to quantization effects.
Key Changes:
- Added a blocklist to the quantization configuration
- Excluded Matmul and KVCache operation types from quantization
- Excluded specific attention-related operations (matmul_qk, matmul_av, k_cache, v_cache) by name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ CI PassedAll checks passed successfully against the following vllm commit: |
|
Is it for performance reason? |
No, dynamic quantization for KVCache+Matmul is a new feature that we don't want to enable by default |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
Signed-off-by: Danny Semiat <[email protected]>
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Currently disabling matmul and kv_cache in dynamic quantization mode