-
Notifications
You must be signed in to change notification settings - Fork 78
Fix the docker image path #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the Docker image path in the quickstart documentation by updating the image name from vllm-installer to vllm-plugin. This ensures users reference the correct Docker images when setting up vLLM on Gaudi hardware.
- Updated Docker image path references from
vllm-installer-{{ PT_VERSION }}tovllm-plugin-{{ PT_VERSION }} - Corrected documentation text describing the Docker image prefix requirement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/getting_started/quickstart/quickstart_configuration.md | Updated three DOCKER_IMAGE variable examples to use the correct vllm-plugin prefix instead of vllm-installer |
| docs/getting_started/quickstart/quickstart.md | Corrected the DOCKER_IMAGE description and example to reference vllm-plugin prefix instead of vllm-installer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: mhelf-intel <[email protected]>
97c0d57 to
c7fe1ea
Compare
Signed-off-by: mhelf-intel <[email protected]>
618b860 to
096703b
Compare
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Fixed the docker image path and replaced the actual Gaudi version in the FAQ document with a variable to avoid manual editing with each release.