14 improve error logging (#18)

* Handle incorrect interval + switch to error

* Fix interval in title of plot

* Throw error instead of info

* Bump patch version

* Fix volume plot

Author: vnegi10

Project.toml

@@ -1,7 +1,7 @@
 name = "CoinbaseProExchange"
 uuid = "06c3450d-869c-4596-88b4-6f9fb82f72bd"
 authors = ["Vikas Negi <vikas.negi10@gmail.com>"]
-version = "1.1.1"
+version = "1.1.2"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

src/helper.jl

@@ -46,4 +46,12 @@ function do_try_catch(endpoint::String, user_data::UserInfo, get_common_df)
     end
 
     return df_data
+end
+
+function closest_interval(interval::Int64)
+
+    _, closest_index = (GRANULARITY .- interval) .|> abs |> findmin
+
+    return GRANULARITY[closest_index]
+
 end

src/plotpublic.jl

@@ -35,14 +35,14 @@ julia> plot_historical_price("ETH-EUR", 86400)
 """
 function plot_historical_price(pair::String, interval::Int64 = 300)
 
-    df_candles = show_historical_data(pair, interval)
+    df_candles, closest_match = show_historical_data(pair, interval)
 
     currency = split(pair, "-")[2]
 
     plt = lineplot(
         df_candles[!, :time],
         df_candles[!, :close],
-        title  = "Closing price for $(pair) in intervals of $(interval) seconds",
+        title  = "Closing price for $(pair) in intervals of $(closest_match) seconds",
         xlabel = "Time",
         ylabel = "Closing price [$(currency)]",
         xticks = true,
@@ -96,14 +96,14 @@ julia> plot_historical_vol("ETH-EUR", 21600)
 """
 function plot_historical_vol(pair::String, interval::Int64 = 300)
 
-    df_candles = show_historical_data(pair, interval)
+    df_candles, closest_match = show_historical_data(pair, interval)
 
     coin = split(pair, "-")[1]
 
     plt = lineplot(
         df_candles[!, :time],
         df_candles[!, :volume],
-        title  = "Volume for $(pair) in intervals of $(interval) seconds",
+        title  = "Volume for $(pair) in intervals of $(closest_match) seconds",
         xlabel = "Time",
         ylabel = "Number of coins [$(coin)]",
         xticks = true,

src/showpublic.jl

@@ -21,7 +21,7 @@ function show_server_time(time_type::String = "iso")
     try
         server_time = get_server_time()
     catch
-        @info "Unable to retrieve API server time"
+        error("Unable to retrieve API server time")
     end
 
     return server_time[time_type]
@@ -52,20 +52,24 @@ julia> show_historical_data("ETH-EUR", 3600)
 function show_historical_data(pair::String, interval::Int64 = 300)
 
     df_candles = DataFrame()
+    closest_match = interval
 
     try
-        df_candles = get_historical_data(pair::String, interval::Int64)
+        df_candles = get_historical_data(pair, interval)
     catch e
         if isa(e, HTTP.ExceptionRequest.StatusError)
-            @info "404 Not Found - Check if the pair ID is valid"
+            error("404 Not Found - Check if the pair ID is valid")
         elseif isa(e, AssertionError)
-            @info "Granularity is NOK, choose only from {60, 300, 900, 3600, 21600, 86400}."
+            @warn("Granularity is NOK, choose only one from {60, 300, 900, 3600, 21600, 86400} seconds.")
+            closest_match = closest_interval(interval)
+            @info("Showing result for closest match $(closest_match)")
+            df_candles = get_historical_data(pair, closest_match)
         else
-            @info "Could not retrieve historical data, try again!"
+            error("Could not retrieve historical data, try again!")
         end
     end
 
-    return df_candles
+    return df_candles, closest_match
 end
 
 
@@ -99,7 +103,7 @@ function show_all_products(currency::String = "USD")
     end
 
     if isempty(products)
-        @info "No products exist for the given currency, try something else!"
+        error("No products exist for the given currency, try something else!")
     else
         return products
     end