Skip to content

Latest commit

 

History

History
54 lines (46 loc) · 1.89 KB

File metadata and controls

54 lines (46 loc) · 1.89 KB

Module PR Triage 2016-08-18

Participants:

  • Hunner
  • eputnam
  • fraq
  • bmjen
  • binford2k
  • tphoney

Discussion

  • You have until Sunday Aug 21 23:59 UTC to vote on our governance documents (no style nits PLEASE!) voxpupuli/plumbing#45
    • It appears that consensus has been removed and all voting will be lazy consensus with 72 hours time slots, condorcet for PMC elections. After discussing it, it seems fine.
    • see https://voxpupuli.org/docs/ for further VP details
  • Migrate puppetlabs-splunk to voxpupuli's namespace
  • eputnam is the newest Puppet module engineer, started this week!
  • google docs sucs for writing markdown. We're switching to etherpad!

Reviews

puppetlabs-apache

  • what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone.
  • 1513: commented
  • 1490: merged
  • 1496: merged
  • 1497: commented
  • 1498: commented
  • 1499: commented
  • 1500: merged
  • 1503: merged

Past Reviews

puppetlabs-aws

  • 334: to discuss after the others are reviewed
  • 330: david to comment and close and submit another bump pr for awssdk
  • 328: needs work
  • 324: commented

puppetlabs-accounts

  • 51: commented. Needs docs. Needs tests

puppetlabs-postgresql

  • 775: See discussion on 2016-07-28
  • 762: commented. Needs to validate passed in params
  • 756: reviewed, 762 looks superior
  • 764: commented - test failures need to be looked at

puppetlabs-apache

  • 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that
  • 1467: merge?
  • 1474: tests fail, dropped in favour of 1486 + 1487
  • 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487
  • 1490: logic needs rework
  • 1491: moved to 1494