yum repo gitlab_official_ce is created even after setting manage_upstream_edition disabled

[shawnxue]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet:4.10
• Ruby: as per puppet
• Distribution: CentOS 7
• Module version:latest (commit 04b2d3e)

How to reproduce (e.g Puppet code you use)

1. I added these 2 parameters in hiera data,
   gitlab::manage_upstream_edition: "disabled"
   gitlab::package_name: "gitlab-ee"
   2: Then I ran puppet

What are you seeing

I saw this message:
Notice: /Stage[main]/Gitlab::Omnibus_package_repository/Yumrepo[gitlab_official_ce]/ensure: current_value absent, should be present (noop)

What behaviour did you expect instead

I expected yum repo "gitlab_official_ce" is not created.

Output log

Any additional information you'd like to impart

[LongLiveCHIEF]

Are you providing your own source repository that you want this module to configure? Or are you wanting to completely handle package installation on your own?

This should have errored out if you set manage_upstream_edition without providing your own repo details.

If you're just trying to use the Enterprise Edition though, and intend to use the automatic gitlab source from package cloud, you don't need to use the package_name param at all, and just set the manage_upstream_repo => ee instead.

Just quoting from the README

If one wants to install Gitlab Enterprise Edition, just define the parameter manage_upstream_edition with the value ee

class { 'gitlab':
  external_url => 'http://gitlab.mydomain.tld',
  manage_upstream_edition      => 'ee',
}

There's definitely some unintended behavior here, but my first priority is to make sure you get the outcome you desire, and I think we can do that without a patch. Give me more info on what your scenario is and I can help make sure you're using the right params.

Also, GitLab's recent announcement about merging repos is going to cause some major refactoring needs (code should be way simpler thankfully). I'm not sure when/if they're going to change the package repo, so we could start seeing strange behavioro (like this) at any time.

I'll open another issue to track the changes needed for this.

[GrabAByte]

I think you need to put the official gitlab repo in your hiera still but with an absent value

# Gitlab Repository Configuration
gitlab::repository_configuration:
  yumrepo:
    "gitlab_official":
      ensure: 'absent'

[LongLiveCHIEF]

@shawnxue how goes it? Did you get things working the way you wanted?