Refactor acceptance tests#283
Draft
jay7x wants to merge 8 commits into
Draft
Conversation
Member
Author
|
Tested this on:
It doesn't work on RHEL10-alikes by 2 reasons:
NOTE: Debian is in a gray area at the moment. There are no official upstream builds of recent rsyslog version. There is OBS repo that has 8.2512 as latest version. I'm not sure if we should support that or wait for any clarification on Debian status (See rsyslog/rsyslog#6767). So far upstream repo is not enabled and the corresponding acceptance test is skipped. |
Member
Author
|
One dropped part is a test with keeping existing OS rsyslog config. I have mixed feelings here. My idea is that we're testing the module, not the OS. I'd prefer maybe to introduce OS-specific default configs instead. |
Member
|
Looks good so far 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.