Merge pull request #2259 from yoyo930021/fix-2258

Fix #2258

Author: octref

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+### 0.xx.xx | 2020-xx-xx |
+- 🙌 Ignore no implicitly any error in v-slot with destructuring. Thanks to contribution from [@yoyo930021](https://github.com/yoyo930021). #2258 and #2259.
+
 ### 0.27.2 | 2020-09-06 | [VSIX](https://marketplace.visualstudio.com/_apis/public/gallery/publishers/octref/vsextensions/vetur/0.27.2/vspackage)
 
 - Add a config `vetur.validation.props` to toggle props validation. Default to false. #2249.

server/src/services/typescriptService/templateDiagnosticFilter.ts

@@ -49,9 +49,9 @@ export function createTemplateDiagnosticFilter(tsModule: T_TypeScript) {
   };
 
   const ignoreNoImplicitAnyViolationInNativeEvent: DiagnosticFilter = diag => {
-    const noImplicitAnyViolation = 7006;
+    const noImplicitAnyViolation = [7006, 7031];
 
-    if (diag.code !== noImplicitAnyViolation) {
+    if (!noImplicitAnyViolation.includes(diag.code)) {
       return true;
     }
 
@@ -61,7 +61,7 @@ export function createTemplateDiagnosticFilter(tsModule: T_TypeScript) {
     }
 
     const target = findNodeFromDiagnostic(diag, source);
-    if (target && tsModule.isParameter(target.parent)) {
+    if (target && (tsModule.isParameter(target.parent) || tsModule.isBindingElement(target.parent))) {
       return false;
     }
 

test/interpolation/features/diagnostics/basic.test.ts

@@ -260,7 +260,8 @@ describe('Should find template-diagnostics in <template> region', () => {
     'hyphen-attrs.vue',
     'template-literal.vue',
     'no-implicit-any-parameters.vue',
-    'no-implicit-any-v-for-array.vue'
+    'no-implicit-any-v-for-array.vue',
+    'issue-2258.vue'
   ];
 
   noErrorTests.forEach(t => {

test/interpolation/fixture/diagnostics/issue-2258.vue

@@ -0,0 +1,10 @@
+<template>
+  <mcOssfileView>
+    <template v-slot="{item}">{{item.name}}</template>
+    <template v-slot:after="item">
+      <div class="info-bar">
+        <div class="text">{{item.name}}</div>
+      </div>
+    </template>
+  </mcOssfileView>
+</template>