Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pagination ignores Magento settings; no configuration as alternative #1406

Open
1 task done
JesseMaxwell opened this issue Dec 27, 2022 · 1 comment
Open
1 task done
Labels
good first issue Good for newcomers triage-needed Issues that need to be checked

Comments

@JesseMaxwell
Copy link

Expected Behavior

Pagination should be driven by Magento's configuration: Magento Admin Panel -> Store Config -> Catalog -> Catalog -> Storefront -> Products per Page on Grid Default Value. Alternatively, there should be a central place where this is defined as a configuration value in the VueStoreFront app.

Actual Behavior

No request for Magento's value is made and multiple places have default different default values hard-coded.

composables/useUiHelpers/index.ts is 10 (getFacetsFromURL)
modules/catalog/category/getters/facetGetters.ts is 20 (getPagination)

Possible Solution

The easiest would be to centralize this pagination setting and load it as a default both places. Ideal would be request from Magento.

Steps to reproduce

  1. Open a category page.
  2. Note the 10 products displayed

What version of Magento 2 integration are you using?

1.0.2

What version of Node.js are you using?

16.13.1

What browser (and version) are you using?

Chrome

What operating system (and version) are you using?

macOS

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JesseMaxwell JesseMaxwell added bug Something isn't working triage-needed Issues that need to be checked labels Dec 27, 2022
@bartoszherba
Copy link
Collaborator

bartoszherba commented Jan 18, 2023

Hello, @JesseMaxwell the configuration value you mention is not exposed via graphql and can't be used in the storefront.
Also, this is not a bug because it works as it should. I changed the qualification from the bug to the enhancement.

@bartoszherba bartoszherba added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working enhancement New feature or request labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers triage-needed Issues that need to be checked
Projects
None yet
Development

No branches or pull requests

2 participants