You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pagination should be driven by Magento's configuration: Magento Admin Panel -> Store Config -> Catalog -> Catalog -> Storefront -> Products per Page on Grid Default Value. Alternatively, there should be a central place where this is defined as a configuration value in the VueStoreFront app.
Actual Behavior
No request for Magento's value is made and multiple places have default different default values hard-coded.
composables/useUiHelpers/index.ts is 10 (getFacetsFromURL) modules/catalog/category/getters/facetGetters.ts is 20 (getPagination)
Possible Solution
The easiest would be to centralize this pagination setting and load it as a default both places. Ideal would be request from Magento.
Steps to reproduce
Open a category page.
Note the 10 products displayed
What version of Magento 2 integration are you using?
1.0.2
What version of Node.js are you using?
16.13.1
What browser (and version) are you using?
Chrome
What operating system (and version) are you using?
macOS
Relevant log output
No response
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
Hello, @JesseMaxwell the configuration value you mention is not exposed via graphql and can't be used in the storefront.
Also, this is not a bug because it works as it should. I changed the qualification from the bug to the enhancement.
Expected Behavior
Pagination should be driven by Magento's configuration: Magento Admin Panel -> Store Config -> Catalog -> Catalog -> Storefront -> Products per Page on Grid Default Value. Alternatively, there should be a central place where this is defined as a configuration value in the VueStoreFront app.
Actual Behavior
No request for Magento's value is made and multiple places have default different default values hard-coded.
composables/useUiHelpers/index.ts
is 10 (getFacetsFromURL
)modules/catalog/category/getters/facetGetters.ts
is 20 (getPagination
)Possible Solution
The easiest would be to centralize this pagination setting and load it as a default both places. Ideal would be request from Magento.
Steps to reproduce
What version of Magento 2 integration are you using?
1.0.2
What version of Node.js are you using?
16.13.1
What browser (and version) are you using?
Chrome
What operating system (and version) are you using?
macOS
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: