07-windowing not recreating commandbuffers with new framebuffers if window didn't resize

[mickvangelderen]

I just started getting serious with this whole vulkan business and there is something in the book that I do not understand. It is about this code here:

vulkano-book/chapter-code/07-windowing/main.rs

Lines 398 to 418 in 8c08e16

	let new_framebuffers = get_framebuffers(&new_images, render_pass.clone());
	if window_resized {
	window_resized = false;
	viewport.extent = new_dimensions.into();
	let new_pipeline = get_pipeline(
	device.clone(),
	vs.clone(),
	fs.clone(),
	render_pass.clone(),
	viewport.clone(),
	);
	command_buffers = get_command_buffers(
	&command_buffer_allocator,
	&queue,
	&new_pipeline,
	&new_framebuffers,
	&vertex_buffer,
	);
	}

There are two booleans: recreate_swapchain and window_resized. The code only recreates the command buffers is window_resized is true, even though they seem to depend on other data (the framebuffers in particular) that is being recreated. Is this intentional or should the if windows_resized check be removed?

[marc0246]

This whole chapter is all wrong. We need to rewrite it. We have some actual good examples over at the vulkano repo.

[mickvangelderen]

All wrong? In that case it would be friendly to add a warning to the top if the rewrite is not going to be out soon.

[mickvangelderen]

@marc0246 Those examples are really good, thanks! Given the amount of documentation through comments, just pointing out the various winit examples in the book would be good enough for me.