Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - LB update timeout missing #513

Open
okdas opened this issue Feb 27, 2025 · 0 comments
Open

[Feature] - LB update timeout missing #513

okdas opened this issue Feb 27, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@okdas
Copy link

okdas commented Feb 27, 2025

Is your feature request related to a problem? Please describe.

Discovered in vultr/vultr-cloud-controller-manager#285.

vultr-cli is missing an option to update load balancer timeout:

~  ❯ vultr version
Vultr-CLI v3.4.0
~  ❯ vultr load-balancer update --help
Update a Load Balancer with the desired settings

Usage:
  vultr-cli load-balancer update <Load Balancer ID> [flags]

Aliases:
  update, u

Examples:

	# Full example
	vultr-cli load-balancer update 57539f6f-66a2-4580-936b-d0af934bce5d --label="Updated Load Balancer Label" \
		--balancing-algorithm="leastconn" --unhealthy-threshold=20

	#Shortened example with aliases
	vultr-cli lb u 57539f6f-66a2-4580-936b-d0af934bce5d -l="Updated Load Balancer Label" -b="leastconn" -u=20

	#Full example with attached VPC
	vultr-cli load-balancer update 57539f6f-66a2-4580-936b-d0af934bce5d --vpc="bff36707-977e-4357-8f30-bef3339155cc"


Flags:
  -b, --balancing-algorithm string     (optional) balancing algorithm that determines server selection | roundrobin or leastconn (default "roundrobin")
      --certificate string             (optional) the SSL certificate.
      --certificate-chain string       (optional) the certificate chain for a ssl certificate.
  -c, --check-interval int             (optional) interval between health checks.
      --cookie-name string             (optional) the cookie name to make sticky.
      --firewall-rules stringArray     (optional) a comma-separated, key-value pair list of firewall rules. Use - between each new rule.
                                       		E.g: "port:80,ip_type:v4,source:0.0.0.0/0-port:8080,ip_type:v4,source:1.1.1.1/4"
  -f, --forwarding-rules stringArray   (optional) a comma-separated, key-value pair list of forwarding rules. Use - between each new rule.
                                       		E.g: "frontend_port:80,frontend_protocol:http,backend_port:80,backend_protocol:http-frontend_port:81,
                                       		frontend_protocol:http,backend_port:81,backend_protocol:http"
      --healthy-threshold int          (optional) number times a check must succeed before returning to healthy status.
  -h, --help                           help for update
  -i, --instances strings              (optional) an array of instances IDs that you want attached to the load balancer.
  -l, --label string                   (optional) the label for your load balancer.
  -n, --nodes int                      (optional) The number of nodes to add to the load balancer (1-99), must be an odd number (default 1)
      --path string                    (optional) HTTP Path to check. only applies if protocol is HTTP or HTTPS.
      --port int                       (optional) the port to use for health checks.
      --private-key string             (optional) the private key component for a ssl certificate.
      --protocol string                (optional) the protocol to use for health checks. | https, http, tcp
  -p, --proxy-protocol                 (optional) if true, you must configure backend nodes to accept Proxy protocol.
  -t, --response-timeout int           (optional) timeout before health check fails.
  -s, --ssl-redirect                   (optional) if true, this will redirect HTTP traffic to HTTPS. You must have an HTTPS rule
                                       		and SSL certificate installed on the load balancer to enable this option.
  -u, --unhealthy-threshold int        (optional) number times a check must fail before becoming unhealthy.
  -v, --vpc string                     (optional) the VPC ID to attach to your load balancer.

Global Flags:
      --config string   config file (default is $HOME/.vultr-cli.yaml) (default "/Users/dk/.vultr-cli.yaml")
  -o, --output string   output format [ text | json | yaml ] (default "text")

Describe the solution you'd like

add a --timeout argument.

Describe alternatives you've considered

There's a workaround currently to update directly via an API:

curl "https://api.vultr.com/v2/load-balancers/${LB_UUID}" \
-X PATCH \
-H "Authorization: Bearer ${VULTR_API_KEY}" \
-H "Content-Type: application/json" \
--data '{
"timeout": 1800
}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants