Skip to content

[css-flexbox-1] Should 'align-content: stretch' use 'safe' in the fallback value? #11641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aethanyc opened this issue Feb 3, 2025 · 5 comments
Labels

Comments

@aethanyc
Copy link

aethanyc commented Feb 3, 2025

Commit b6c01a4 makes align-content: stretch fallback to safe flex-start in css-flexbox-1 https://drafts.csswg.org/css-flexbox-1/#valdef-align-content-stretch, which is not consistent with the fallback flex-start specifying in css-align-3 https://drafts.csswg.org/css-align-3/#valdef-align-content-stretch.

Is this an editorial error or intentional?

@aethanyc
Copy link
Author

aethanyc commented Feb 3, 2025

I have a PR #11554 to fix the flexbox spec if this is just an error.

@Loirooriol
Copy link
Contributor

<!DOCTYPE html>
<div style="display: inline-flex; border: solid; height: 50px; flex-wrap: wrap-reverse; align-content: stretch">
  <div style="width: 100px; height: 100px; background: cyan"></div>
</div>
<div style="display: inline-flex; border: solid; height: 50px; flex-wrap: wrap-reverse; align-content: flex-start">
  <div style="width: 100px; height: 100px; background: cyan"></div>
</div>
<div style="display: inline-flex; border: solid; height: 50px; flex-wrap: wrap-reverse; align-content: safe flex-start">
  <div style="width: 100px; height: 100px; background: cyan"></div>
</div>

Gecko, Blink and WebKit use flex-start. Servo uses safe flex-start.

@Loirooriol Loirooriol added css-flexbox-1 Current Work css-align-3 Current Work labels Feb 3, 2025
@fantasai
Copy link
Collaborator

Agenda+ to confirm with the CSSWG.

@fantasai
Copy link
Collaborator

(I think this is the right thing to do, just want to confirm that we want to do it.)

@Loirooriol
Copy link
Contributor

Which one do you think is the right thing, safe or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Regular agenda
Development

No branches or pull requests

3 participants