Skip to content

Commit 15ca899

Browse files
scottaoharascottaohara
committed
cut down rowspan/colspan rules for now
closes #338 further updates for these attributes and other table related rules need to be tracked in #258
1 parent c9343ad commit 15ca899

File tree

4 files changed

+26
-49
lines changed

4 files changed

+26
-49
lines changed

‎index.html

+14-6
Original file line numberDiff line numberDiff line change
@@ -3107,14 +3107,18 @@ <h3 id="docconformance-attr">
31073107
Use the `colspan` attribute on any element that is
31083108
allowed the `colspan` attribute in HTML.
31093109
</p>
3110+
<!--
3111+
Removing per issue #338
3112+
Revised rules to be re-added
31103113
<p>
3111-
Authors MAY use the `aria-colspan` attribute on any element that is allowed the `colspan` attribute in HTML, or any element with a WAI-ARIA role which allows the <a data-cite="wai-aria-1.1#aria-colspan">`aria-colspan` attribute</a>.
3114+
Authors MAY use the <a data-cite="wai-aria-1.1#aria-colspan">`aria-colspan`</a> attribute on any element with an explicit WAI-ARIA role which allows the `aria-colspan` attribute.
31123115
</p>
3116+
-->
31133117
<p>
3114-
Authors SHOULD NOT use the `aria-colspan` attribute on any element which also has a `colspan` attribute.
3118+
Authors SHOULD NOT use the `aria-colspan` attribute on any element which allows the `colspan` attribute. Use the `colspan` attribute instead.
31153119
</p>
31163120
<p>
3117-
Authors MUST NOT use `aria-colspan` on any element which also has a `colspan` attribute, and the values of each attribute do not match.
3121+
Authors MUST NOT use `aria-colspan` on any element which also has a `colspan` attribute and the values of each attribute do not match.
31183122
</p>
31193123
</td>
31203124
</tr>
@@ -3131,14 +3135,18 @@ <h3 id="docconformance-attr">
31313135
Use the `rowspan` attribute on any element that is
31323136
allowed the `rowspan` attribute in HTML.
31333137
</p>
3138+
<!--
3139+
Removing per issue #338
3140+
Revised rules to be re-added
31343141
<p>
3135-
Authors MAY use the `aria-rowspan` attribute on any element that is allowed the `rowspan` attribute in HTML, or any element with a WAI-ARIA role which allows the <a data-cite="wai-aria-1.1#aria-rowspan">`aria-rowspan` attribute</a>.
3142+
Authors MAY use the <a data-cite="wai-aria-1.1#aria-rowspan">`aria-rowspan`</a> attribute on any element with an explicit WAI-ARIA role which allows the `aria-rowspan` attribute.
31363143
</p>
3144+
-->
31373145
<p>
3138-
Authors SHOULD NOT use the `aria-rowspan` attribute on any element which also has a `rowspan` attribute.
3146+
Authors SHOULD NOT use the `aria-rowspan` attribute on any element which allows the `rowspan` attribute. Use the `rowspan` attribute instead.
31393147
</p>
31403148
<p>
3141-
Authors MUST NOT use `aria-rowspan` on any element which also has a `rowspan` attribute, and the values of each attribute do not match.
3149+
Authors MUST NOT use `aria-rowspan` on any element which also has a `rowspan` attribute and the values of each attribute do not match.
31423150
</p>
31433151
</td>
31443152
</tr>

‎results/implementation-results.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -3696,12 +3696,12 @@ <h2>Conformance Checker Rule Implementations</h2>
36963696
Use the <code>colspan</code> attribute on any element that is
36973697
allowed the <code>colspan</code> attribute in HTML.
36983698
</p>
3699-
<p>
3699+
<!-- <p>
37003700
Authors <em class="rfc2119">MAY</em> use the <code>aria-colspan</code> attribute on any element that is allowed the <code>colspan</code> attribute in HTML, or any element with a WAI-<abbr title="Accessible Rich Internet Applications">ARIA</abbr> role which allows the <code>aria-colspan</code> attribute.
37013701
</p>
37023702
<p>
37033703
Authors <em class="rfc2119">SHOULD NOT</em> use the <code>aria-colspan</code> attribute on any element which also has a <code>colspan</code> attribute.
3704-
</p>
3704+
</p> -->
37053705
<p>
37063706
Authors <em class="rfc2119">MUST NOT</em> use <code>aria-colspan</code> on any element which also has a <code>colspan</code> attribute, and the values of each attribute do not match.
37073707
</p>
@@ -3724,12 +3724,12 @@ <h2>Conformance Checker Rule Implementations</h2>
37243724
Use the <code>rowspan</code> attribute on any element that is
37253725
allowed the <code>rowspan</code> attribute in HTML.
37263726
</p>
3727-
<p>
3727+
<!-- <p>
37283728
Authors <em class="rfc2119">MAY</em> use the <code>aria-rowspan</code> attribute on any element that is allowed the <code>rowspan</code> attribute in HTML, or any element with a WAI-<abbr title="Accessible Rich Internet Applications">ARIA</abbr> role which allows the <code>aria-rowspan</code> attribute.
37293729
</p>
37303730
<p>
37313731
Authors <em class="rfc2119">SHOULD NOT</em> use the <code>aria-rowspan</code> attribute on any element which also has a <code>rowspan</code> attribute.
3732-
</p>
3732+
</p> -->
37333733
<p>
37343734
Authors <em class="rfc2119">MUST NOT</em> use <code>aria-rowspan</code> on any element which also has a <code>rowspan</code> attribute, and the values of each attribute do not match.
37353735
</p>

‎tests/colspan-test.html

+6-20
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
<header>
4848
<h1>ARIA in HTML - test cases for <code>aria-colspan</code></h1>
49-
<p>last updated 27 February 2021</p>
49+
<p>last updated 18 August 2021</p>
5050
<p>
5151
<a href="https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements"><code>colspan</code></a> is allowed on <code>td</code> and <code>th</code> elements
5252
</p>
@@ -57,24 +57,7 @@ <h2>Tests:</h2>
5757
<div class="flex">
5858
<div class="widgetDemo">
5959
<h3>Test 1</h3>
60-
<p>Authors MAY use the <code>aria-colspan</code> attribute on any element that is allowed the <code>colspan</code> attribute in HTML, or any element with a WAI-ARIA role which allows the <code>aria-colspan</code> attribute. </p>
61-
62-
<p>The first <code>th</code> and <code>td</code> each have an <code>aria-colspan="1"</code></p>
63-
64-
<div class="testcase">
65-
<table>
66-
<thead>
67-
<tr><th aria-colspan="1">header 1</th><th>header 2</th></tr>
68-
</thead>
69-
<tr>
70-
<td aria-colspan="1">Cell 1</td>
71-
<td>Cell 2</td>
72-
</tr>
73-
</table>
74-
</div>
75-
76-
<p><strong>Expected result:</strong>
77-
<br> no warning/error</p>
60+
Edit: removed test.
7861
</div>
7962

8063
<div class="widgetDemo">
@@ -86,7 +69,10 @@ <h3>Test 2</h3>
8669
<div class="testcase">
8770
<table>
8871
<thead>
89-
<tr><th aria-colspan="1" colspan="1">header 1</th><th>header 2</th></tr>
72+
<tr>
73+
<th aria-colspan="1" colspan="1">header 1</th>
74+
<th>header 2</th>
75+
</tr>
9076
</thead>
9177
<tr>
9278
<td aria-colspan="1" colspan="1">Cell 1</td>

‎tests/rowspan-test.html

+2-19
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
<header>
4848
<h1>ARIA in HTML - test cases for <code>aria-rowspan</code></h1>
49-
<p>last updated 27 February 2021</p>
49+
<p>last updated 18 August 2021</p>
5050
<p>
5151
<a href="https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements"><code>rowspan</code></a> is allowed on <code>td</code> and <code>th</code> elements
5252
</p>
@@ -57,24 +57,7 @@ <h2>Tests:</h2>
5757
<div class="flex">
5858
<div class="widgetDemo">
5959
<h3>Test 1</h3>
60-
<p>Authors MAY use the <code>aria-rowspan</code> attribute on any element that is allowed the <code>rowspan</code> attribute in HTML, or any element with a WAI-ARIA role which allows the <code>aria-rowspan</code> attribute. </p>
61-
62-
<p>The first <code>th</code> and <code>td</code> each have an <code>aria-rowspan="1"</code></p>
63-
64-
<div class="testcase">
65-
<table>
66-
<thead>
67-
<tr><th aria-rowspan="1">header 1</th><th>header 2</th></tr>
68-
</thead>
69-
<tr>
70-
<td aria-rowspan="1">Cell 1</td>
71-
<td>Cell 2</td>
72-
</tr>
73-
</table>
74-
</div>
75-
76-
<p><strong>Expected result:</strong>
77-
<br> no warning/error</p>
60+
Edit: removed test.
7861
</div>
7962

8063
<div class="widgetDemo">

0 commit comments

Comments
 (0)