-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marching Percussion instruments need unique Sound IDs #494
Comments
At the risk of over-complicating this: Perhaps adding these would lend to more comprehensive fall-back options sound id="drum.bass-drum.pipe-band"/ This is all open for discussion. I can submit a PR for this as well. |
this seems reasonable. I'm inclined to accept. The sounds are quite different than orchestra. Might need flam variants for snares. |
Please let me know if there is anything else I can do to help here :) |
sorry! I was sick for a month and everything has gotten a bit behind. Hoping to jump on this soon. |
Adding Sound IDs for marching percussion instruments will allow them to be identified uniquely.
I would propose using these sound ids.
sound id="drum.snare-drum.marching"/
sound id="drum.snare-line.marching"/
sound id="drum.tenor-drum.marching"/
sound id="drum.tenor-line.marching"/
sound id="drum.multi-tenor-drum.marching"/
sound id="drum.multi-tenor-line.marching"/
sound id="drum.bass-line.marching"/
sound id="metal.cymbals.marching"/
sound id="drum.snare-drum.pipe-band"/
sound id="drum.tenor-drum.pipe-band"/
sound id="drum.bass-drum.pipe-band"/
Some programs define a solo marching drum and a drumline differently. Pipe band drummers use 'chips' to switch between solo drum and drumline.
The text was updated successfully, but these errors were encountered: