Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interception only for requests that are actually sent over the wire #792

Open
OrKoN opened this issue Sep 27, 2024 · 1 comment
Open
Labels
module-network Network module needs-discussion Issues to be discussed by the working group

Comments

@OrKoN
Copy link
Contributor

OrKoN commented Sep 27, 2024

We noticed that the current spec draft whatwg/fetch#1540 indicates that request interception should work even if the request is handled from cache.

In Chromium, this will be difficult to support since a lot of cache handling is happening synchronously and current implementations only covers actual requests that go out to the network.

We also currently do not have a use case for intercepting already cached requests so we would like to update the draft to support interception (but not logging) only for non-cached requests that will be actually sent to the network.

Alternatively, if we allow intercepting requests that have cached responses and the user changes headers, those would not reach the server since the response has already been cached leading to confusing results.

WDYT?

@sadym-chromium @alexnj @jgraham @whimboo

@OrKoN OrKoN added needs-discussion Issues to be discussed by the working group module-network Network module labels Sep 27, 2024
@whimboo
Copy link
Contributor

whimboo commented Sep 27, 2024

CC @juliandescottes who knows more about the network layer in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-network Network module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

2 participants