Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema Issues #2

Open
egekorkan opened this issue May 15, 2024 · 3 comments
Open

JSON Schema Issues #2

egekorkan opened this issue May 15, 2024 · 3 comments

Comments

@egekorkan
Copy link
Contributor

egekorkan commented May 15, 2024

  • additionalProperties is false everywhere where it should be true
  • No properties in the top level: Testing the JSON schema against some bad TDs, seems to validate anything I give it to https://www.jsonschemavalidator.net/s/zU8fEe6N
  • Human readability: The schema is not very human readable. It is not a deal breaker but a negative aspect for sure
@egekorkan egekorkan changed the title JSON Schema validates pretty much anything? JSON Schema Issues May 15, 2024
@danielpeintner
Copy link

It seems that the JSON schema defines types like ActionAffordance as part of $defs but nothing ever points to it...

@egekorkan
Copy link
Contributor Author

The "simple" issue is that we are not linking to #/$defs/Thing from the root level. We can fix it manually but we should be able to generate it automatically

@egekorkan
Copy link
Contributor Author

@mahdanoura should we close this issue and open issues for new stuff? This is quite outdated at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants