Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus: pending/complete #52

Open
martinthomson opened this issue Sep 4, 2024 · 0 comments
Open

Focus: pending/complete #52

martinthomson opened this issue Sep 4, 2024 · 0 comments

Comments

@martinthomson
Copy link
Contributor

martinthomson commented Sep 4, 2024

@hober notes in #49:

As an overall comment: I think we're unlikely to need the complexity/granularity of the Focus: $FOO (pending)/Focus: $FOO (complete) labeling system, and we're unlikely to actually do it. Too many fiddly bits.

Originally posted by @hober in #49 (comment)

This pending/complete thing predates that change, so it's worth opening a new issue to discuss it. I agree with the sentiment above: tracking whether something is complete or not with labels sounds neat, but in practice I suggest that it would be easier to:

  1. Mark things with focus areas.
  2. Before closing, manually verify that an appropriate level of review in each of those areas has been provided.

The value of labels lies in the support they provide for process, but each additional transition adds overhead. That overhead seems unnecessary in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant