Improve app-version wait loop #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wait loop that waits for apps to be published and at the current version does did not handle the case of the app not being propagated to Edge servers yet , in which case the version header would be missing entirely, leading to an immediate abort. This change now also waits for Edge to recognise the app.
| } catch (err) { | ||
| console.error(err); | ||
| } | ||
| } |
There was a problem hiding this comment.
shouldn't we have continue in here? With current code even if response failed, we would still continue the flow and check for headers which likely not there for a failed response.
Collaborator
Author
There was a problem hiding this comment.
Yeah fair point.
Well, in particular, we'd want to continue on 400 "app not found" errors.
But not on other errors.
(except maybe overload)
baalimago
approved these changes
Oct 27, 2025
Collaborator
baalimago
left a comment
baalimago
left a comment
There was a problem hiding this comment.
It will improve visibility, although I suspect that it'll just fail the tests one level down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wait loop that waits for apps to be published and at the current
version does did not handle the case of the app not being propagated to
Edge servers yet , in which case the version header would be missing
entirely, leading to an immediate abort.
This change now also waits for Edge to recognise the app.