Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Improve bit depth over the codebase #86

Open
Shinyzenith opened this issue Feb 12, 2024 · 5 comments
Open

Todo: Improve bit depth over the codebase #86

Shinyzenith opened this issue Feb 12, 2024 · 5 comments

Comments

@Shinyzenith
Copy link
Member

Some parts of our codebase have hardcoded 8 bit for PNG outputs, we should ideally choose 16 bit as that is the maximum supported depth for PNG encoding.

@utkarshdagoat
Copy link

Can I be assigned to this issue?
cc @Shinyzenith (we had a conservation on discord about this)

@Shinyzenith
Copy link
Member Author

Hi Utkarsh, I believe @nukelet over on the discord had asked to work on this. If you can get a patch ready then I'd suggest to go for it.

@utkarshdagoat
Copy link

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

@nukelet
Copy link

nukelet commented Feb 28, 2024

Hi! Yes, I'm working on this right now and planning to send a patch very soon. 🙂

@Shinyzenith
Copy link
Member Author

Shinyzenith commented Feb 28, 2024

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

#87 is up for grabs but fair warning, the freeze pr set introduced a lot of significant API and cli changes so pick your poison wisely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants