fix: Filter alerts on name (was type) #4724
Open
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdangkhoa
changed the title
htdangkhoa
changed the title
erikgb
changed the title
erikgb
changed the title
|
@htdangkhoa Is it possible to add/modify tests to verify the desired behavior? I am not a frontend developer, but hopefully, some of our other collaborators can give some concrete advice on the matter. |
|
@erikgb thank you for your answer, I added the unit test for my change |
|
Cheers, will take a look soon but we should also get a few other front end reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4723
What changed?
Why was this change made?
I think the alerts should be filtering on provider name instead of type.
How was this change implemented?
In fact, users can configure another provider's name than the type's name of Flux provided (e.g. Name: discord-bot, type: discord)
How did you validate the change?
Unit test is added
Release notes
The alerts are not shown on the table
Documentation Changes
No