Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: About Vue 3 hot update #3217

Open
MinGuoGuo opened this issue Aug 15, 2024 · 14 comments
Open

[Bug]: About Vue 3 hot update #3217

MinGuoGuo opened this issue Aug 15, 2024 · 14 comments
Labels
🐞 bug Something isn't working

Comments

@MinGuoGuo
Copy link

Version

mac m1pro
chorme
rsbuild最新版本

Details

我用rsbuild新建的vue3模板,热更新是对当前页面的全量替换,不会保留当前页面的state,我只是在template里面更新了ui,script里面的state都会重新初始,感觉这样体验很不好,这一点的表现和webpack,vite都有所不同。复现仓库链接:https://gitee.com/xiangminya/rsbuild-hmr 该仓库里面分别用rsbuild和vite初始化了一个项目,修改UI热跟新表现不一致

Reproduce link

https://gitee.com/xiangminya/rsbuild-hmr

Reproduce Steps

详细问题可到仓库查看

@MinGuoGuo MinGuoGuo added the 🐞 bug Something isn't working label Aug 15, 2024
@chenjiahan chenjiahan changed the title [Bug]: 关于热更新 [Bug]: About Vue 3 hot update Aug 15, 2024
@witsaint
Copy link

@chenjiahan This Issure looks like it came from rspack. I started the service with Rpack and liveReload was still working。

@witsaint
Copy link

HMR took effect when I set devtool: false

@chenjiahan
Copy link
Member

Maybe related to Vue itslef? vuejs/core#3250

@MinGuoGuo
Copy link
Author

@chenjiahan oh my god,看起来他们那个issue已经open长达三年时间了😭

@witsaint
Copy link

I have run it with webpack and hmr can work normally, which is not the same as the vue issue

@MinGuoGuo
Copy link
Author

@witsaint Yes, HMR can run normally in both webpack and Vite, so I don't know why it doesn't work properly in RSBuild

@SoonIter
Copy link
Member

SoonIter commented Aug 15, 2024

Related to the template caching feature in vite-plugin-vue
vitejs/vite-plugin-vue#386

But the template caching is not available in vue-loader

@witsaint
Copy link

@chenjiahan Over the weekend, I probably found out the reason: the module returned in hot.xx.js does not match the moduleid of hot.accept in the code inserted by vue-loader. There are too many modules returned, and due content will be overwritten in runtime, so the callback of hot.accept is not executed

@witsaint
Copy link

Key code in hmr

@MinGuoGuo
Copy link
Author

@chenjiahan dalao,will this be fixed as a bug in future versions

@chenjiahan
Copy link
Member

Yes it should be fixed if it is a bug of Rspack. PR welcome~

@MinGuoGuo
Copy link
Author

@witsaint 大佬提个pr给修复下呗,菜鸡膜拜

@wanghao1993
Copy link

@chenjiahan dalao,will this be fixed as a bug in future versions

笑死了哥,dalao 这翻译666

@MinGuoGuo
Copy link
Author

@chenjiahan dalao,will this be fixed as a bug in future versions

笑死了哥,dalao 这翻译666

你就说能不能看懂吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants