Skip to content

Commit d73db74

Browse files
celestepanchromium-wpt-export-bot
authored andcommitted
[Masonry] Call ClampIntrinsicBlockSize in Grid-Lanes
This method has two main parts: 1) the call to `CalculateIntrinsicBlockSizeIgnoringChildren`, which takes care of how `select multiple` and `textarea` should affect block size. There are already tests to account for this in grid-lanes, and they were already passing, so no new tests were added. 2) applying "fill viewport" in quirks mode, which a test was added for. Bug: 343257585 Change-Id: I8f37e140f974b6dcea7826d959d2860619622d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7545446 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Celeste Pan <celestepan@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1581088}
1 parent f82bcac commit d73db74

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<!doctype quirks><!-- Intentional quirks mode -->
2+
<style>
3+
html {
4+
margin:3px 6px 9px 12px;
5+
padding: 0px;
6+
background-color: green;
7+
}
8+
body {
9+
display: grid;
10+
margin: 7px 11px 14px 23px;
11+
padding: 0px;
12+
background-color: yellow;
13+
}
14+
</style>
15+
<p>This is test text.</p>
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<!doctype quirks><!-- Intentional quirks mode -->
2+
<title>CSS Test: Grid Lanes body in quirks mode should fill viewport except for margins</title>
3+
<link rel="author" title="Celeste Pan" href="celestepan@microsoft.com">
4+
<link rel="help" href="https://drafts.csswg.org/css-grid-3">
5+
<link rel="help" href="https://quirks.spec.whatwg.org/#the-body-element-fills-the-html-element-quirk" title="The body element fills the html element quirk">
6+
<link rel="match" href="grid-lanes-quirks-fill-viewport-ref.html">
7+
<style>
8+
html {
9+
margin:3px 6px 9px 12px;
10+
padding: 0px;
11+
background-color: green;
12+
}
13+
body {
14+
display: grid-lanes;
15+
margin: 7px 11px 14px 23px;
16+
padding: 0px;
17+
background-color: yellow;
18+
}
19+
</style>
20+
<p>This is test text.</p>

0 commit comments

Comments
 (0)