Bug fixed with ECDSA signatures

Spomky · Spomky · commit ba72c18f1783 · 2017-10-15T16:58:35.000+02:00
diff --git a/src/Component/Core/Util/ECSignature.php b/src/Component/Core/Util/ECSignature.php
@@ -92,7 +92,7 @@ private static function preparePositiveInteger(string $data): string
         if (mb_substr($data, 0, 2, '8bit') >= '7f') {
             return '00'.$data;
         }
-        while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') < '7f') {
+        while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') <= '7f') {
             $data = mb_substr($data, 2, null, '8bit');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ private static function preparePositiveInteger(string $data): string`
`92`	`92`	`if (mb_substr($data, 0, 2, '8bit') >= '7f') {`
`93`	`93`	`return '00'.$data;`
`94`	`94`	`}`
`95`		`- while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') < '7f') {`
	`95`	`+ while ('00' === mb_substr($data, 0, 2, '8bit') && mb_substr($data, 2, 2, '8bit') <= '7f') {`
`96`	`96`	`$data = mb_substr($data, 2, null, '8bit');`
`97`	`97`	`}`
`98`	`98`