Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs-extra dependency #50

Open
serbanghita opened this issue Apr 24, 2019 · 5 comments
Open

Remove fs-extra dependency #50

serbanghita opened this issue Apr 24, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@serbanghita
Copy link
Collaborator

@stsvilik I looked over the way we use "fs-extra": "^7.0.0", package and I believe we can get rid of the dependency by having a bunch of local functions in src/utils based on fs native module. Let me know your thoughts on this.

@serbanghita serbanghita added the enhancement New feature or request label Apr 24, 2019
@stsvilik
Copy link
Collaborator

Thats definitely possible - will need to promisify native fs and some refactoring around checking for log files writeability.

@seanpoulter
Copy link
Contributor

Node 16 shipped with fs/promises. This should be easy if it is still something you'd like to do.
What version of Node.js do you expect to support? Can we add that in engines.node in package.json?

@christian-bromann
Copy link
Collaborator

+1 on this change 👍

@christian-bromann
Copy link
Collaborator

Please not that there is a rewrite on going in #126, so let's coordinate this with the work done by @dons20

@seanpoulter
Copy link
Contributor

It also looks like we don't have GitHub workflows configured. Let me know if there are any incremental changes you'd like me to make to help. If I don't hear anything I'll wait for #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants