Improve performance by disabling runtime value validation #1797
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out expensive runtime validation checks to improve query execution performance: - Removed null check for non-nullable fields (lines 887-889) - Removed is_iterable check for list types (lines 900-904) Based on benchmarks showing 100-200ms improvements for queries. Addresses issue webonyx#1493
Collaborator
|
Fine experiment, but I can not merge this pull request in this state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out expensive runtime validation checks to improve query execution performance:
Based on benchmarks showing 100-200ms improvements for queries.
Addresses issue #1493