Skip to content

Commit 844c453

Browse files
chore: fix todo
1 parent bc7d1d4 commit 844c453

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

test/serve/invalid-schema/__snapshots__/invalid-schema.test.js.snap.devServer5.webpack5

+7
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,10 @@ exports[`invalid schema should log webpack-dev-server error and exit process on
2828
`;
2929

3030
exports[`invalid schema should log webpack-dev-server error and exit process on invalid config: stdout 1`] = `""`;
31+
32+
exports[`invalid schema should log webpack-dev-server error and exit process on invalid flag: stderr 1`] = `
33+
"[webpack-cli] Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
34+
- options.port should be >= 0 and <= 65535."
35+
`;
36+
37+
exports[`invalid schema should log webpack-dev-server error and exit process on invalid flag: stdout 1`] = `""`;

test/serve/invalid-schema/invalid-schema.test.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ describe("invalid schema", () => {
2222
expect(normalizeStdout(stdout)).toMatchSnapshot("stdout");
2323
});
2424

25-
// TODO need fix on webpack-dev-server side
26-
it.skip("should log webpack-dev-server error and exit process on invalid flag", async () => {
25+
it("should log webpack-dev-server error and exit process on invalid flag", async () => {
2726
const { exitCode, stderr, stdout } = await run(__dirname, ["serve", "--port", "-1"]);
2827

2928
expect(exitCode).toEqual(2);

0 commit comments

Comments
 (0)